Remove of in-memory cache, and check for gzipped files. Remerge of PR #36#100
Merged
Conversation
…but adding .gz to the end can be served up to clients that support it. As part of that, changed the code so the Content-Type and Content-Length are sent even for an HTTP HEAD request.
…gth was sent with a 304 not modified response.
…If-None-Match' and 'If-Modified-Since' correctly.
Collaborator
There was a problem hiding this comment.
Could you fix this merge comment, please?
Contributor
Author
|
Hello @phstc Did you see the updates I did a week ago, according to your comments? |
Collaborator
|
Hi @thbaja I will check in this weekend, sorry for the delay. |
phstc
added a commit
that referenced
this pull request
Jun 28, 2013
Remove of in-memory cache, and check for gzipped files. Remerge of PR #36
Collaborator
|
@thbaja could you also update the README about the mentions to the cache in memory, please? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested in issue #90, I have attempted to do a remerge of pull request #36.
I have also made som minor fixes, so that it passes the tests that have been added since the original pull request.
It does fail one test however, but this is due to another issue, which is already documented here: #99
✗ head must has no body » expected '' to be undefined // node-static-test.js:185