Check for Roles when retrieving operator credentials#523
Closed
rebeccachin wants to merge 1 commit into
Closed
Conversation
|
Hey rebeccachin! Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA. |
Contributor
|
@rebeccachin Can you please provide more detail about exactly what is going on with this PR? As the commit message does not describe what the change was and why the change was made, I'm not sure if this was accidentally submitted to the project or if you expect it to be incorporated. |
[#151847755] Signed-off-by: Rebecca Chin <rchin@pivotal.io> Signed-off-by: Emily Casey <ecasey@pivotal.io> Signed-off-by: Gavin Enns <genns@pivotal.io>
Contributor
|
We rebased this. This PR provides forwards compatibility with new pcc credentials format that will be landing in pcc v1.3.0. |
Contributor
|
Any updates on this? |
Contributor
|
It’s scheduled for the next release and will be included when that release goes out. |
Contributor
|
awesome thanks! |
nebhale
approved these changes
Nov 30, 2017
ramonskie
pushed a commit
that referenced
this pull request
Dec 4, 2025
Previously, the implementation hard-coded the expected username of 'cluster- operator' for connections. Changes to the service are coming that will allow alternate usernames to be used. This change updates the code to properly handle those alternate usernames so long as they have the cluster-operator role. [resolves #523][#151847755] Signed-off-by: Rebecca Chin <rchin@pivotal.io> Signed-off-by: Emily Casey <ecasey@pivotal.io> Signed-off-by: Gavin Enns <genns@pivotal.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[#151847755]
Signed-off-by: Rebecca Chin rchin@pivotal.io