Skip to content

Update JAVA_OPTS documentation - #520

Closed
youngm wants to merge 1 commit into
cloudfoundry:masterfrom
youngm:patch-2
Closed

Update JAVA_OPTS documentation#520
youngm wants to merge 1 commit into
cloudfoundry:masterfrom
youngm:patch-2

Conversation

@youngm

@youngm youngm commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

A stab at updating some JAVA_OPTS documentation for JBP4.

@cfdreddbot

Copy link
Copy Markdown

Hey youngm!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nebhale
nebhale self-requested a review November 10, 2017 18:29
@nebhale nebhale self-assigned this Nov 10, 2017
@nebhale nebhale added this to the v4.7 milestone Nov 10, 2017
@nebhale

nebhale commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

Looks great. What do you think about removing -Xmx specifically. I cannot think of a single case where setting that would be anything but wrong.

@youngm

youngm commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

We could. Though I actually set that for an application, as a stop gap, that was having trouble staying within the container memory size while I study the problem. We set it to a value that we believed should leave plenty of head room for everything else. It was convenient.

That said I won't have a problem with making it an undocumented feature if you would prefer.

@nebhale

nebhale commented Nov 10, 2017

Copy link
Copy Markdown
Contributor

Yeah, let's make it undocumented. I understand your use case, but I don't want any indication in our docs that it's an appropriate thing for most users to do. Those who really need it should be able to divine that it's possible for the pattern of the rest.

A stab at updating some JAVA_OPTS documentation for JBP4.
@youngm

youngm commented Nov 10, 2017

Copy link
Copy Markdown
Contributor Author

@nebhale done.

@nebhale nebhale closed this in 972a559 Nov 10, 2017
@nebhale nebhale reopened this Nov 10, 2017
@cfdreddbot

Copy link
Copy Markdown

Hey youngm!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nebhale nebhale closed this Nov 10, 2017
ramonskie pushed a commit that referenced this pull request Dec 4, 2025
Previously the JAVA_OPTS documentation erroneously stated that there were a
set of allowed and disallowed memory arguments.  With the advent of the new
memory calculator all flags are now allowed.  This change updates the docs to
reflect that.

[resolves #520]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants