Skip to content

Make it possible to disable auto-activation of JRebel - #457

Closed
dmitri-gb wants to merge 1 commit into
cloudfoundry:masterfrom
dmitri-gb:master
Closed

Make it possible to disable auto-activation of JRebel#457
dmitri-gb wants to merge 1 commit into
cloudfoundry:masterfrom
dmitri-gb:master

Conversation

@dmitri-gb

Copy link
Copy Markdown
Contributor

No description provided.

@cfdreddbot

Copy link
Copy Markdown

Hey dmitri-gb!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

@nebhale
nebhale self-requested a review July 4, 2017 14:40
@nebhale nebhale self-assigned this Jul 4, 2017
@nebhale nebhale added this to the v3.19 milestone Jul 4, 2017
@nebhale

nebhale commented Jul 4, 2017

Copy link
Copy Markdown
Contributor

What's the need for this? Wouldn't you just not package your application without rebel-remote.xml if you didn't want that behavior?

@dmitri-gb

Copy link
Copy Markdown
Contributor Author

@nebhale Yes, one could also just leave out the xml file. However, we've had clients who keep this file in their source code repository and deploy to multiple environments (dev, staging, production). They have expressed the wish to be able to disable JRebel through other means (env vars etc).

@nebhale nebhale closed this in 8ba9dd3 Jul 5, 2017
chook pushed a commit to takipi/java-buildpack that referenced this pull request Jul 23, 2017
This change adds a flag to the JRebel configuration that allows users to
explicitly disable the JRebel framework.

[resolves cloudfoundry#457]
ramonskie pushed a commit that referenced this pull request Dec 4, 2025
This change adds a flag to the JRebel configuration that allows users to
explicitly disable the JRebel framework.

[resolves #457]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants