[#145612229] add session state caching support for geode by Jammy-Louie · Pull Request #437 · cloudfoundry/java-buildpack

Jammy-Louie · 2017-06-02T14:39:10Z

Pull request to Support Session State Caching for Pivotal Cloud Cache (Gemfire)

cfdreddbot · 2017-06-02T14:39:11Z

Hey pivotal-Jammy-Louie!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

nebhale

Before I even do a review of the code, this needs to be updated so as not to remove the contents of .idea/ and not exclude them. This information is intentionally kept under source control as it is a good indicator that your system is not setup in an authoritative way when it changes.

Jammy-Louie · 2017-06-02T15:04:32Z

Updated the branch not to ignore .idea/ and include the infrastructural files

nebhale

In addition to the changes listed here (which are for the most part structurally sound), you'll also need to add some documentation to the Tomcat docs about this integration. This will probably be helpful.

nebhale · 2017-06-02T16:25:27Z

    addressable (2.5.1)
      public_suffix (~> 2.0, >= 2.0.2)
    ast (2.3.0)
+    coderay (1.1.1)


This file should not be modified.

nebhale · 2017-06-02T16:29:11Z

  connection_pool_size: 2
+geode_store:
+  version: 0.+
+  repository_root: "https://tomcat-javabuildpack-spike.s3.amazonaws.com/geode-store"


This doesn't seem like a production version of this bucket URI. Also, for performance reasons, buckets hosted on S3 should probably exposed via CloudFront.

in the process of find out where i can place the tar

Sounds good.

If the code really is Geode, and is all backed by an ASL repository, we could host it for you.

all but one jar is from Geode

Where is that one file from? Is it GemFire branded?

the jar is called pcc-client-auth

Yeah, it'll need to be a public repository with a permissive license for us to host it. This goes back to the fact that the CFF needs to take a special exception for US export compliance that can only be satisfied by 100% open source code.

nebhale · 2017-06-02T16:29:25Z

        app_dir = Pathname.new(File.expand_path(app_dir))
        Logging::LoggerFactory.instance.setup app_dir
        application = Component::Application.new(app_dir)
-


This line should not be removed.

nebhale · 2017-06-02T16:29:38Z

          TomcatLoggingSupport.new(sub_configuration_context(context, 'logging_support')),
          TomcatAccessLoggingSupport.new(sub_configuration_context(context, 'access_logging_support')),
          TomcatRedisStore.new(sub_configuration_context(context, 'redis_store')),
+          TomcatGeodeStore.new(sub_configuration_context(context, 'geode_store')),


This should be sorted alphabetically.

nebhale · 2017-06-02T16:42:18Z

 require 'java_buildpack/container'
 require 'java_buildpack/container/tomcat/tomcat_insight_support'
 require 'java_buildpack/container/tomcat/tomcat_instance'
+require 'java_buildpack/container/tomcat/tomcat_geode_store'


This should be sorted alphabetically.

nebhale · 2017-06-02T17:50:39Z

+  context 'when there is a session-replication service' do
+    before do
+      allow(services).to receive(:one_service?).with(/session-replication/, 'locators', 'users')
+        .and_return(true)


You'll want to run bundle exec rake to ensure that your code meets all formatting requirements. The Rubocop task will give you pointers on where the code needs to change.

nebhale · 2017-06-02T17:51:05Z

 require 'java_buildpack/container/tomcat'
 require 'java_buildpack/container/tomcat/tomcat_insight_support'
 require 'java_buildpack/container/tomcat/tomcat_instance'
+require 'java_buildpack/container/tomcat/tomcat_geode_store'


Alphabetize

nebhale · 2017-06-02T17:51:13Z

  let(:configuration) do
    { 'tomcat'                 => tomcat_configuration,
      'lifecycle_support'      => lifecycle_support_configuration,
+      'geode_store'            => geode_store_configuration,


Alphabetize

nebhale · 2017-06-02T17:51:27Z

      .to receive(:new).with(sub_configuration_context(tomcat_configuration))
    allow(JavaBuildpack::Container::TomcatLifecycleSupport)
      .to receive(:new).with(sub_configuration_context(lifecycle_support_configuration))
+    allow(JavaBuildpack::Container::TomcatGeodeStore)


Alphabetize

nebhale · 2017-06-02T17:51:37Z


  let(:logging_support_configuration) { instance_double('logging-support-configuration') }

+  let(:geode_store_configuration) { instance_double('geode_store_configuration') }


Alphabetize

nebhale · 2017-06-02T22:06:01Z

@pivotal-Jammy-Louie Also noticed that you need to take care of publicizing your CLA compliance.

nebhale · 2017-06-02T22:10:26Z

OK, looks like just the repository outstanding and then we can merge. Let's chat Monday morning about what the options are there.

cfdreddbot · 2017-06-05T15:45:21Z

Hey pivotal-Jammy-Louie!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

nebhale · 2017-06-12T17:39:09Z

@pivotal-Jammy-Louie Can you please publicize your org so that the CLA is satisfied?

nebhale · 2017-06-19T16:29:36Z

@pivotal-Jammy-Louie We're still waiting on you to publicize your GitHub org membership to identify that you've signed the CLA.

Signed-off-by: Emily Casey <ecasey@pivotal.io>

files

…lease and compile

cfdreddbot · 2017-07-04T14:39:58Z

Hey pivotal-Jammy-Louie!

Thanks for submitting this pull request!

All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate).

When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization.

If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions.

Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look.

Jammy-Louie · 2017-07-05T18:08:01Z

I have my Org. I apologize for the delay

cfdreddbot · 2017-07-06T07:19:11Z

Hey pivotal-Jammy-Louie!

Thanks for submitting this pull request! I'm here to inform the recipients of the pull request that you and the commit authors have already signed the CLA.

nebhale · 2017-07-06T07:19:36Z

Great. The PR is more or less ready to go now, after we determine the hosting thing.

pulkit-chandra · 2017-07-17T20:08:28Z

I think this PR is ready to be merged, please let us know @nebhale if you have more feedback on it.

nebhale · 2017-07-17T21:11:19Z

https://java-buildpack.cloudfoundry.org/geode-store/index.yml
https://java-buildpack.cloudfoundry.org/geode-store/geode-store-0.0.2.tar.gz

This change adds support for the Pivotal Cloud Cache as a Tomcat Session Manager. Binding to a Pivotal Cloud Cache service instance will cause Tomcat to use it as a session store. [resolves cloudfoundry#437]

luisapace · 2017-10-26T08:22:02Z

@pivotal-Jammy-Louie
Hi Jammy,
I've had your name and this thread from Neb Hale, I kindly ask you if you can help me or redirect this to the responsible people.

I am an IBM employee working in legal team and my goal is to analyze with some software tools the source code and the license of all open sources and their dependencies to check if they can be included in our products without legal issues (in .cc a colleague working with me).

Currently I'm analyzing the java buildpack 3.19 code to verify if we can include it in our code without legal problems; to do that I've to analyze it and all its dependencies chain.

Now, the java buildpack 3.19 calls as dependency - with the name Apache Geode Tomcat Session Store - the zip file at:https://java-buildpack.cloudfoundry.org/geode-store/geode-store-0.0.2.tar.gz, that in turn include some jar files that seems to be NOT open source, but commercial code, Pivotal proprietary:
geode-core-9.0.3.jar
geode-modules-9.0.3.jar
geode-modules-tomcat8-9.0.3.jar
pcc-client-auth-0.0.1.jar

Could you please confirm me if they are commercial code or opensource?

If they are opensource could you please point me to the download location of their source.

Feel free to ask us other details if you need.

Thanks for your support.

This change adds support for the Pivotal Cloud Cache as a Tomcat Session Manager. Binding to a Pivotal Cloud Cache service instance will cause Tomcat to use it as a session store. [resolves #437]

nebhale self-assigned this Jun 2, 2017

nebhale added this to the v3.18 milestone Jun 2, 2017

nebhale suggested changes Jun 2, 2017

View reviewed changes

Jammy-Louie closed this Jun 5, 2017

Jammy-Louie deleted the ssc-gemfire branch June 5, 2017 15:40

Jammy-Louie restored the ssc-gemfire branch June 5, 2017 15:42

nebhale reopened this Jun 5, 2017

nebhale modified the milestones: v3.19, v3.18 Jun 19, 2017

Petahhh and others added 5 commits June 28, 2017 10:48

[#145612229] add session state caching support for geode

f403450

Signed-off-by: Emily Casey <ecasey@pivotal.io>

do not ignore .idea directory and ensure we include the infrastructure

e291806

files

make changes as asked per PR

58ec767

fix build pack compile issue. reintroduce the check for support in re…

e8bf0bb

…lease and compile

Fix merge conflicts

8158283

nebhale closed this Jul 4, 2017

nebhale reopened this Jul 4, 2017

nebhale closed this Jul 6, 2017

nebhale reopened this Jul 6, 2017

nebhale closed this in 0e5a542 Jul 17, 2017


		let(:logging_support_configuration) { instance_double('logging-support-configuration') }

		let(:geode_store_configuration) { instance_double('geode_store_configuration') }

Uh oh!

Conversation

Jammy-Louie commented Jun 2, 2017

Uh oh!

cfdreddbot commented Jun 2, 2017

Uh oh!

nebhale left a comment

Choose a reason for hiding this comment

Uh oh!

Jammy-Louie commented Jun 2, 2017

Uh oh!

nebhale left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

nebhale commented Jun 2, 2017

Uh oh!

nebhale commented Jun 2, 2017

Uh oh!

cfdreddbot commented Jun 5, 2017

Uh oh!

nebhale commented Jun 12, 2017

Uh oh!

nebhale commented Jun 19, 2017

Uh oh!

cfdreddbot commented Jul 4, 2017

Uh oh!

Jammy-Louie commented Jul 5, 2017

Uh oh!

cfdreddbot commented Jul 6, 2017

Uh oh!

nebhale commented Jul 6, 2017

Uh oh!

pulkit-chandra commented Jul 17, 2017

Uh oh!

nebhale commented Jul 17, 2017

Uh oh!

luisapace commented Oct 26, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants