Add support for Insight Agent NG - #40
Conversation
[#64790832] Signed-off-by: Dave Tillman <dtillman@gopivotal.com>
[#64790832] Signed-off-by: Dave Tillman <dtillman@gopivotal.com>
|
Hey benjaminleesmith! Thanks for submitting this pull request! All pull request authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. |
|
|
|
@benjaminleesmith A couple of general comments and I'll add more detailed ones in-line in the code. First, please review the contributor guidelines and update the code. Ideally, there should be a single squashed commit with a more descriptive commit message (take a look at some others for examples). As well, the code should be re-based on top of the latest |
There was a problem hiding this comment.
What is the point of this change? I could understand something like /[Ii]nsight/, but I'm not sure what the point of the ^p is.
|
The stub-insight-agent file is 36M (!!). That doesn't sound like a stub to me. Anything larger than 1-2K must be trimmed down. |
No description provided.