ProtectApp Security Provider Release#385
Conversation
|
Hey chrisjdhanley! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
| # Configuration for the ProtectApp Security Provider framework | ||
| --- | ||
| version: 8.4.+ | ||
| repository_root: http://files.cf-hsm.io/protectapp-installer |
There was a problem hiding this comment.
While the index.yml is now in place, the file that it points to doesn't exist yet (or the index is wrong).
There was a problem hiding this comment.
index.yml was wrong. Should be updated tommorrow
| In order to create the credentials payload, you should collapse the JSON payload to a single line and set it like the following | ||
|
|
||
| ``` | ||
| $ cf create-user-provided-service protectapp -p '{"client":{"certificate":"-----BEGIN CERTIFICATE-----\n....\n-----END CERTIFICATE-----","private-key":"-----BEGIN RSA PRIVATE KEY-----\n...\n-----END RSA PRIVATE KEY-----\n"},"trustedcerts":{"-----BEGIN CERTIFICATE-----\n...\n-----END CERTIFICATE-----"},NAE_IP.1":"172.17.34.100"} |
There was a problem hiding this comment.
trustedcerts is an array, not a hash.
| | `version` | Version of the ProtectApp Security Provider to use. | ||
|
|
||
| ### Additional Resources | ||
| The framework can also be configured by overlaying a set of resources on the default distribution. To do this, add files to the `resources/protectapp_security_provider` directory in the buildpack fork. |
There was a problem hiding this comment.
Should be resources/protect_app_security_provider.
| ## Configuration | ||
| For general information on configuring the buildpack, including how to specify configuration values through environment variables, refer to [Configuration and Extension][]. | ||
|
|
||
| The framework can be configured by modifying the [`config/protectapp_security_provider.yml`][] file in the buildpack. The framework uses the [`Repository` utility support][repositories] and so it supports the [version syntax][] defined there. |
There was a problem hiding this comment.
Should be config/protect_app_security_provider.yml
| ### Additional Resources | ||
| The framework can also be configured by overlaying a set of resources on the default distribution. To do this, add files to the `resources/protectapp_security_provider` directory in the buildpack fork. | ||
|
|
||
| [`config/protectapp_security_provider.yml`]: ../config/protectapp_security_provider.yml |
There was a problem hiding this comment.
Should be config/protect_app_security_provider.yml
98fceaa to
b1cd087
Compare
|
All the other changes were made, I'll send a note when I get the index.yml fixed. |
| | `version` | Version of the ProtectApp Security Provider to use. | ||
|
|
||
| ### Additional Resources | ||
| The framework can also be configured by overlaying a set of resources on the default distribution. To do this, add files to the `resources/pprotect_app_security_provider` directory in the buildpack fork. |
There was a problem hiding this comment.
pprotect_app... I'll get it when I do the polishing.
This change adds support for the ProtectApp Security Provider service. [#385]
This change adds support for the ProtectApp Security Provider service. [#385]
No description provided.