Add Dyadic EKM buildpack - #365
Conversation
|
Hey peer85! Thanks for submitting this pull request! All pull request submitters and commit authors must have a Contributor License Agreement (CLA) on-file with us. Please sign the appropriate CLA (individual or corporate). When sending signed CLA please provide your github username in case of individual CLA or the list of github usernames that can make pull requests on behalf of your organization. If you are confident that you're covered under a Corporate CLA, please make sure you've publicized your membership in the appropriate Github Org, per these instructions. Once you've publicized your membership, one of the owners of this repository can close and reopen this pull request, and dreddbot will take another look. |
nebhale
left a comment
There was a problem hiding this comment.
In addition to the items mentioned below (which are all cosmetic really), there are no tests. In the interests of getting this merged as quickly as possible I'll make the changes and write the tests (the Luna support is a good template, so it should go quickly). I'd encourage you to review the updates once they are complete so that future PR's around this code go in smoothly.
| --- | ||
| version: 1.+ | ||
| repository_root: https://repo.dyadicsec.com/cust/pcf | ||
| logging_enabled: false |
There was a problem hiding this comment.
I don't believe that you've added support for configuring logging, so this entry can be removed.
| download_tar | ||
| setup_ext_dir | ||
|
|
||
| @droplet.copy_resources |
There was a problem hiding this comment.
This file generally needs a reformat. If you're using IntelliJ, we've checked the formatting rules into source control, so you can use the code formatter there to fix it all to our standard.
| end | ||
|
|
||
| def write_conf(servers,send_timeout,recv_timeout,retries) | ||
| conf_file.open(File::CREAT | File::WRONLY) do |f| |
There was a problem hiding this comment.
Need to ensure that the parent directory exists before writing with FileUtils.mkdir_p conf_file.parent.
| end | ||
|
|
||
| def write_cert(cert) | ||
| cert_file.open(File::CREAT | File::WRONLY) do |f| |
There was a problem hiding this comment.
Need to ensure that the parent directory exists before writing with FileUtils.mkdir_p cert_file.parent.
| end | ||
|
|
||
| def write_key(key) | ||
| key_file.open(File::CREAT | File::WRONLY) do |f| |
There was a problem hiding this comment.
Need to ensure that the parent directory exists before writing with FileUtils.mkdir_p key_file.parent.
| # (see JavaBuildpack::Component::VersionedDependencyComponent#supports?) | ||
| def supports? | ||
| @application.services.one_service? FILTER | ||
| #true |
There was a problem hiding this comment.
Remove commented out code.
| # (see JavaBuildpack::Component::BaseComponent#release) | ||
| def release | ||
| @droplet | ||
| .java_opts |
There was a problem hiding this comment.
All of the .java_opts can be combined into a single chained invocation.
|
|
||
| def write_conf(servers,send_timeout,recv_timeout,retries) | ||
| conf_file.open(File::CREAT | File::WRONLY) do |f| | ||
| f.write "servers = " + servers + "\n" |
There was a problem hiding this comment.
This multiline string can be rewritten as a single Ruby multi-line interpolation like:
f.write <<EOS
servers = #{servers}
send_timeout = #{send_timeout}
recv_timeout = #{recv_timeout}
retries = #{retries}
EOSThis change adds a framework that detects service instances for the Dyadic EKM and configures an application to use it as a Java Security Provider. [#365]
This change adds a framework that detects service instances for the Dyadic EKM and configures an application to use it as a Java Security Provider. [#365]
No description provided.