update node.js streams implementation by anonrig · Pull Request #5298 · cloudflare/workerd

anonrig · 2025-10-13T19:44:32Z

Updates Node.js streams implementation to latest while making it more type-safe.

github-actions · 2025-10-13T19:47:01Z

The generated output of @cloudflare/workers-types matches the snapshot in types/generated-snapshot 🎉

jasnell

Overall the changes look fine except for the fact that this likely needs to be gated with a compat flag and the original behavior preserved, unfortuntely...

To expand a bit: I am not comfortable approving this as it is. There are definitely a number of commits that are semver-major changes in node.js included and given the way this PR was structured (all in one commit where large chunks are moved around and edited without clear diffs of what specifically was changed).. it's not really possible to determine what possible breaking changes are included.

This change is definitely needed, but the PR needs to be restructured to make it easier to review and likely needs to be gated behind a compat flag that preserves the original behavior.

codspeed-hq · 2025-10-22T21:17:48Z

CodSpeed Performance Report

Merging #5298 will not alter performance

_{Comparing yagiz/update-streams-impl (4d384ee) with main (48cfcb1)}

Summary

✅ 33 untouched
⏩ 9 skipped¹

9 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

anonrig · 2025-10-24T23:51:44Z

rebasing

anonrig requested a review from jasnell October 13, 2025 19:44

anonrig requested review from a team as code owners October 13, 2025 19:44

anonrig requested a review from a team October 13, 2025 19:44

anonrig requested a review from a team as a code owner October 13, 2025 19:44

anonrig force-pushed the yagiz/update-streams-impl branch 10 times, most recently from 030c4bc to 354d70f Compare October 14, 2025 19:31

anonrig mentioned this pull request Oct 14, 2025

properly handle errors on compile cache generation #5309

Merged

anonrig requested review from guybedford and npaun October 14, 2025 19:34

jasnell reviewed Oct 15, 2025

View reviewed changes

Comment thread src/node/internal/streams_destroy.ts

jasnell reviewed Oct 15, 2025

View reviewed changes

Comment thread src/node/internal/streams_destroy.ts

jasnell reviewed Oct 15, 2025

View reviewed changes

Comment thread src/node/internal/streams_end_of_stream.ts