Skip to content

proof of concept for message durability with small files (fit a batch request) #2

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apuig wants to merge 16 commits into
base: master
Choose a base branch
from
Open

proof of concept for message durability with small files (fit a batch request) #2

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
16 commits
Select commit Hold shift + click to select a range
24fcc00
fix OOM error in test
apuig Mar 19, 2025
8d81420
setup wiremock test
apuig Mar 20, 2025
3d232fa
remove
apuig Mar 20, 2025
82fb908
simple wiremock test
apuig Mar 21, 2025
205e2de
remove callback
apuig Mar 24, 2025
af74b24
remove backo, add failsafe
apuig Mar 24, 2025
85ef909
fallback appender
apuig Mar 25, 2025
ab780a4
values
apuig Mar 25, 2025
2d06abf
doc
apuig Mar 26, 2025
f73e156
stole ReversedLinesFileReader at commons-io:2.18.0
apuig Mar 31, 2025
0d2527e
ReversedLinesFileReader truncate consumed lines
apuig Mar 31, 2025
389875f
truncate lines on resend
apuig Mar 31, 2025
ac0bc1f
stop retry on rate limit
apuig Mar 31, 2025
e100ede
store small batch size
apuig Apr 1, 2025
eb58c68
fix end of batch in tmp files. Change test execution
apuig Apr 10, 2025
10a5ac6
cleanup
apuig Apr 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
remove backo, add failsafe
  • Loading branch information
@apuig
apuig committed Mar 25, 2025
commit af74b24ed91b875d15fa419f5ce56a2743cf50b2
12 changes: 10 additions & 2 deletions analytics/pom.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,18 @@
<artifactId>findbugs</artifactId>
<scope>provided</scope>
</dependency>

<dependency>
<groupId>com.segment.backo</groupId>
<artifactId>backo</artifactId>
<groupId>dev.failsafe</groupId>
<artifactId>failsafe</artifactId>
<version>3.3.2</version>
</dependency>
<dependency>
<groupId>dev.failsafe</groupId>
<artifactId>failsafe-retrofit</artifactId>
<version>3.3.2</version>
</dependency>

<dependency>
<groupId>junit</groupId>
<artifactId>junit</artifactId>
Expand Down
40 changes: 11 additions & 29 deletions analytics/src/main/java/com/segment/analytics/Analytics.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -139,7 +139,6 @@ public static class Builder {
private ThreadFactory threadFactory;
private int flushQueueSize;
private int maximumFlushAttempts;
private int maximumQueueSizeInBytes;
private long flushIntervalInMillis;
private int queueCapacity;
private boolean forceTlsV1 = false;
Expand Down Expand Up @@ -267,17 +266,6 @@ public Builder flushQueueSize(int flushQueueSize) {
return this;
}

/** Set the queueSize at which flushes should be triggered. */
@Beta
public Builder maximumQueueSizeInBytes(int bytes) {
if (bytes < 1) {
throw new IllegalArgumentException("maximumQueueSizeInBytes must not be less than 1.");
}

this.maximumQueueSizeInBytes = bytes;
return this;
}

/** Set the interval at which the queue should be flushed. */
@Beta
public Builder flushInterval(long flushInterval, TimeUnit unit) {
Expand Down Expand Up @@ -369,9 +357,6 @@ public Analytics build() {
if (flushQueueSize == 0) {
flushQueueSize = Platform.get().defaultFlushQueueSize();
}
if (maximumQueueSizeInBytes == 0) {
maximumQueueSizeInBytes = MESSAGE_QUEUE_MAX_BYTE_SIZE;
}
if (maximumFlushAttempts == 0) {
maximumFlushAttempts = 3;
}
Expand Down Expand Up @@ -430,20 +415,17 @@ public void log(String message) {

SegmentService segmentService = restAdapter.create(SegmentService.class);

AnalyticsClient analyticsClient =
AnalyticsClient.create(
endpoint,
segmentService,
queueCapacity,
flushQueueSize,
flushIntervalInMillis,
maximumFlushAttempts,
maximumQueueSizeInBytes,
log,
threadFactory,
networkExecutor,
writeKey,
gson);
AnalyticsClient analyticsClient = AnalyticsClient.create(
endpoint,
segmentService,
queueCapacity,
flushQueueSize,
flushIntervalInMillis,
log,
threadFactory,
networkExecutor,
writeKey,
gson);

return new Analytics(analyticsClient, messageTransformers, messageInterceptors, log);
}
Expand Down
Loading