Skip to content

proof of concept for message durability #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
apuig wants to merge 13 commits into
base: master
Choose a base branch
from
Open

proof of concept for message durability #1

Changes from 1 commit
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
24fcc00
fix OOM error in test
apuig Mar 19, 2025
8d81420
setup wiremock test
apuig Mar 20, 2025
3d232fa
remove
apuig Mar 20, 2025
82fb908
simple wiremock test
apuig Mar 21, 2025
205e2de
remove callback
apuig Mar 24, 2025
af74b24
remove backo, add failsafe
apuig Mar 24, 2025
85ef909
fallback appender
apuig Mar 25, 2025
ab780a4
values
apuig Mar 25, 2025
2d06abf
doc
apuig Mar 26, 2025
f73e156
stole ReversedLinesFileReader at commons-io:2.18.0
apuig Mar 31, 2025
0d2527e
ReversedLinesFileReader truncate consumed lines
apuig Mar 31, 2025
389875f
truncate lines on resend
apuig Mar 31, 2025
ac0bc1f
stop retry on rate limit
apuig Mar 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ReversedLinesFileReader truncate consumed lines
  • Loading branch information
@apuig
apuig committed Mar 31, 2025
commit 0d2527e51861969230463b7fe15becdfe9dc3710
19 changes: 15 additions & 4 deletions analytics/src/main/java/com/segment/analytics/internal/ReversedLinesFileReader.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,11 +21,11 @@
import java.io.IOException;
import java.io.UnsupportedEncodingException;
import java.nio.ByteBuffer;
import java.nio.channels.SeekableByteChannel;
import java.nio.channels.FileChannel;
import java.nio.channels.FileLock;
import java.nio.charset.Charset;
import java.nio.charset.CharsetEncoder;
import java.nio.charset.StandardCharsets;
import java.nio.file.Files;
import java.nio.file.Path;
import java.nio.file.StandardOpenOption;
import java.util.ArrayList;
Expand Down Expand Up @@ -278,7 +278,8 @@ public static Builder builder() {

private final int blockSize;
private final Charset charset;
private final SeekableByteChannel channel;
private final FileChannel channel;
private final FileLock fileLock;
private final long totalByteLength;
private final long totalBlockCount;
private final byte[][] newLineSequences;
Expand Down Expand Up @@ -422,7 +423,8 @@ public ReversedLinesFileReader(final Path file, final int blockSize, final Chars
this.avoidNewlineSplitBufferSize = newLineSequences[0].length;

// Open file
this.channel = Files.newByteChannel(file, StandardOpenOption.READ);
this.channel = FileChannel.open(file, StandardOpenOption.READ, StandardOpenOption.WRITE);
this.fileLock = channel.lock();
this.totalByteLength = channel.size();
int lastBlockLength = (int) (this.totalByteLength % blockSize);
if (lastBlockLength > 0) {
Expand Down Expand Up @@ -461,6 +463,7 @@ public ReversedLinesFileReader(final Path file, final int blockSize, final Strin
*/
@Override
public void close() throws IOException {
fileLock.release();
channel.close();
}

Expand Down Expand Up @@ -514,10 +517,18 @@ public List<String> readLines(final int lineCount) throws IOException {
for (int i = 0; i < lineCount; i++) {
final String line = readLine();
if (line == null) {
channel.truncate(0);
return arrayList;
}
arrayList.add(line);
}

long truncateTo = (this.currentFilePart.no - 1) * blockSize;
truncateTo += this.currentFilePart.currentLastBytePos + 1;
channel.truncate(truncateTo);

channel.force(true);

return arrayList;
}

Expand Down