Skip to content

Add --list flag in gh config command#864

Closed
jan25 wants to merge 6 commits intocli:masterfrom
jan25:issue-859
Closed

Add --list flag in gh config command#864
jan25 wants to merge 6 commits intocli:masterfrom
jan25:issue-859

Conversation

@jan25
Copy link
Copy Markdown
Contributor

@jan25 jan25 commented May 5, 2020

Fixes #859

  • This PR assumes we will only ever use scalar values in config.yml
  • Added hidden placeholder implementation for future host flag in gh config --list

TODO

Write tests for yaml.FlattenYamlNode
Update docs

jan25 added 3 commits May 5, 2020 17:36
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25 jan25 changed the title WIP Add --list flag in git config command WIP Add --list flag in gh config command May 5, 2020
jan25 added 3 commits May 5, 2020 18:29
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
Signed-off-by: Abhilash Gnan <abhilashgnan@gmail.com>
@jan25 jan25 changed the title WIP Add --list flag in gh config command Add --list flag in gh config command May 17, 2020
@mislav
Copy link
Copy Markdown
Contributor

mislav commented May 25, 2020

Hi, thank you for the proposal, but per our CONTRIBUTING policy we are currently not accepting PRs for features that we haven't discussed nor approved yet.

Listing available config options is certainly an interesting idea and I wouldn't be opposed to exploring that, but for now I think it's premature to add it, especially because we haven't discussed at all about what would be its output format and its intended purpose.

@mislav mislav closed this May 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh config list

2 participants