Skip to content

Add ability to comment on close/reopen of issues/pull requests#5437

Merged
samcoe merged 2 commits into
trunkfrom
close-comments
Apr 11, 2022
Merged

Add ability to comment on close/reopen of issues/pull requests#5437
samcoe merged 2 commits into
trunkfrom
close-comments

Conversation

@samcoe
Copy link
Copy Markdown
Contributor

@samcoe samcoe commented Apr 11, 2022

This PR adds the ability to leave a comment when closing/reopening issues and pull requests. We already have issue comment and pr comment so these new flags are meant to be shortcuts for the issue comment && issue close workflows. They purposefully do not support anything besides inline text input as I didn't want to add unnecessary complexity to these simple commands. For more advanced text input the issue comment and pr comment commands should still be used.

Closes #1038

@samcoe samcoe requested a review from a team as a code owner April 11, 2022 09:24
@samcoe samcoe self-assigned this Apr 11, 2022
@samcoe samcoe requested review from mislav and removed request for a team April 11, 2022 09:24
Copy link
Copy Markdown
Contributor

@mislav mislav left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@samcoe samcoe merged commit 6fa8e42 into trunk Apr 11, 2022
@samcoe samcoe deleted the close-comments branch April 11, 2022 15:06
@mislav mislav mentioned this pull request Jun 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gh pr close with comment?

3 participants