Fix namespaced skill install file tree output - #14254
Open
Hiro5409 wants to merge 1 commit into
Open
Conversation
Contributor
|
Thanks for your pull request! While it doesn't meet all of our standard requirements, it appears to be a small, focused contribution and has been routed to the team for review. Note: We still encourage linking to an issue with the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #14190
Description
Namespaced skills install into flat directories, but the post-install file tree still resolves their qualified names as nested paths. Successful installs therefore display
(could not read directory).Resolve each file-tree entry from its flat on-disk name while preserving the qualified name in the success message. The
InstallNamecomment now describes the returned name instead of the obsolete nested install layout.How did you test this change?
Given a local skill at
src/skills/alice/deploy/SKILL.md, I ran:Before, the install succeeded but displayed:
After, it displayed the installed directory and file:
The installed file remained at
target/deploy/SKILL.md.Key points
alice/deploy). Only the tree label and the directory it reads use the flat name.printFileTreederives the flat name from the qualified name it already receives, so the installer'sResultshape stays unchanged.Notes for reviewers
The behavior change is in
printFileTree, which both the repository and--from-localinstall paths call. The regression assertion extends the existing namespaced local-install table case.#13266 introduced the flat install layout that this output now follows.
Authorship and follow-up
Who wrote this:
Who answers review comments: