Skip to content

Don't recommend nix-env in installation instructions - #14021

Closed
NyCodeGHG wants to merge 1 commit into
cli:trunkfrom
NyCodeGHG:patch-1
Closed

Don't recommend nix-env in installation instructions#14021
NyCodeGHG wants to merge 1 commit into
cli:trunkfrom
NyCodeGHG:patch-1

Conversation

@NyCodeGHG

Copy link
Copy Markdown

Description

nix-env is a giant footgun, it shouldn't be recommended to end users.

How did you test this change?

Tried both new mentioned installation methods.

Key points

Keep the existing footgun and let users shoot themselves in the foot -> bad idea

Notes for reviewers

Authorship and follow-up

Who wrote this:

  • A human wrote it.
  • An agent wrote it under close human direction.
  • An agent wrote it independently, and no human has guided the implementation beyond the initial prompt.

Who answers review comments:

I will reply if needed

nix-env is a giant footgun, it shouldn't be recommended to end users.
@NyCodeGHG
NyCodeGHG requested a review from a team as a code owner July 30, 2026 19:43
@NyCodeGHG
NyCodeGHG requested a review from tidy-dev July 30, 2026 19:43
@github-actions github-actions Bot added external pull request originating outside of the CLI core team needs-triage needs to be reviewed ready-for-review and removed needs-triage needs to be reviewed labels Jul 30, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Thanks for your pull request! While it doesn't meet all of our standard requirements, it appears to be a small, focused contribution and has been routed to the team for review.

Note: We still encourage linking to an issue with the help wanted label when possible, as it helps us prioritize and track contributions.

@babakks

babakks commented Jul 31, 2026

Copy link
Copy Markdown
Member

Thanks for your feedback, @NyCodeGHG! 🙏 However, I'd appreciate it if you could open up an issue so that we can discuss this first. I'm closing this PR to free up review backlog, but we can reopen it once we decided to go with the changes.

@babakks babakks closed this Jul 31, 2026
ThodsaphonSonthiphin pushed a commit to ThodsaphonSonthiphin/workflow-daily-work that referenced this pull request Aug 3, 2026
…er probe harness

Two corrections to the probe work committed in bb33b9e.

1. The line-ending claim was wrong. One probe body round-tripped as LF, and
   that was generalised into "no line-ending rewrite". Both forms occur in
   real issue bodies -- cli/cli#14021 comes back CRLF, cli/cli#14031 LF, same
   repo, both with HTML comments intact; the submission path decides. The
   contract now requires every backend to normalise to \n on read before
   parsing or comparing, and to write \n. Without it a human's web-UI edit can
   flip a region to CRLF and the next chart reports every line as changed,
   breaking the byte-identical no-op guarantee on text nobody touched. The key
   marker is single-line and safe either way; region content is not.

2. Replaced the ad-hoc GitHub-only script with the real harness,
   probe_marker_survival.py: both trackers, dry-run by DEFAULT, --yes plus an
   explicit target required to write, --phase setup/verify/cleanup/auto with
   state in a file so the human web-UI step works non-interactively, cleanup in
   try/finally, write throttling. Exercised end to end against the throwaway
   private repo: 34 API calls, seven steps PASS, cleanup fired.

   It is better than what it replaces in two ways that matter. It normalises
   CRLF before byte-comparing -- the exact bug in correction 1. And it refuses
   to report markerSurvives from steps 1 and 4 alone, emitting null plus "do
   not write join code on steps 1/4 alone" until step 3 is really run; the
   retired script would have implied a pass. The retired script also claimed
   issues cannot be deleted -- true of REST, false of GraphQL deleteIssue,
   which the harness uses for --purge.

   Its ADO adapter is written from Microsoft Learn reference docs and has
   NEVER been executed. Treat it as unexercised code, not a verified path.

Also recorded from the grounding pass: dependencies cap at 50 per relationship
type (separate from the 100 sub-issue cap); a sub-issue need only share the
parent's OWNER, so it may live in another repo and the join must key on parent
identity rather than "same repo"; and DELETE takes the singular /sub_issue path
with the id in the request body.

Both verdicts are kept: the human-step-3 run is the authoritative evidence, the
harness run is the reproducible baseline that honestly reports itself undecided.

Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
@babakks

babakks commented Aug 3, 2026

Copy link
Copy Markdown
Member

I made #14045 for this.

@babakks

babakks commented Aug 3, 2026

Copy link
Copy Markdown
Member

@NyCodeGHG, I think we should just mention the use of nix-shell in our docs and point the user to the NixOS packages site for more installation options. If you could update this PR accordingly, I'll reopen it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

external pull request originating outside of the CLI core team ready-for-review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants