fix: support non-zipped artifacts in gh run download#13524
Open
ShahabAhmed01 wants to merge 1 commit into
Open
fix: support non-zipped artifacts in gh run download#13524ShahabAhmed01 wants to merge 1 commit into
ShahabAhmed01 wants to merge 1 commit into
Conversation
Check Content-Type header to detect non-zipped artifacts and write them directly to destination without attempting to unzip. This fixes the issue where GitHub Actions now supports uploading artifacts with archive: false. Fixes cli#13012
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13012
GitHub Actions now supports uploading artifacts with
archive: false, but the CLI always attempts to unzip artifacts regardless of their format. This causes a "not a valid zip file" error when downloading non-zipped artifacts.Root Cause
The
downloadArtifactfunction inhttp.goalways treats downloaded artifacts as zip files and attempts to extract them without checking the Content-Type header.Fix
application/ziporapplication/x-zip-compressed, write the file directly to destination without attempting to unzipChanges
platforminterface to accept artifact name parameterdownloadArtifactto check Content-Type and handle non-zipped artifactsTesting