add --all flag to install all skills in a repo#13471
Open
tommaso-moro wants to merge 3 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a --all option to gh skill install to install every discovered skill from a repository without specifying an individual skill, reusing the existing “install all skills” selection path (including collision detection), and extends tests to cover flag parsing and remote multi-skill installs.
Changes:
- Add
--allflag handling and validation togh skill install. - Reuse the existing “all skills” selection flow by short-circuiting selection when
--allis set. - Update help/examples and expand tests for parsing and remote installation of multiple skills.
Show a summary per file
| File | Description |
|---|---|
| pkg/cmd/skills/install/install.go | Adds --all flag, validation, help text, and selection behavior to install all discovered skills. |
| pkg/cmd/skills/install/install_test.go | Adds parsing coverage for --all and a new test ensuring remote multi-skill install works with --all. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comments suppressed due to low confidence (1)
pkg/cmd/skills/install/install.go:227
- Flag help for
--allsays "without prompting", butgh skill install --allmay still prompt for agent/scope selection in interactive mode. Consider clarifying that it installs all discovered skills without prompting for which skills to install.
cmdutil.StringEnumFlag(cmd, &opts.Scope, "scope", "", "project", []string{"project", "user"}, "Installation scope")
cmd.Flags().StringVar(&opts.Pin, "pin", "", "Pin to a specific git tag or commit SHA")
cmd.Flags().StringVar(&opts.Dir, "dir", "", "Install to a custom directory (overrides --agent and --scope)")
cmd.Flags().BoolVar(&opts.All, "all", false, "Install all skills without prompting")
cmd.Flags().BoolVarP(&opts.Force, "force", "f", false, "Overwrite existing skills without prompting")
- Files reviewed: 2/2 changed files
- Comments generated: 2
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13453
Summary
--alltogh skill installso users can install every discovered skill from a repository without providing an individual skill name.Testing
go test ./pkg/cmd/skills/install