Improve update --all command if some skills don't have metadata#13469
Open
tommaso-moro wants to merge 2 commits into
Open
Improve update --all command if some skills don't have metadata#13469tommaso-moro wants to merge 2 commits into
tommaso-moro wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes gh skill update --all so it no longer triggers interactive prompts for installed skills that are missing GitHub metadata, aligning --all with its “without prompting” behavior.
Changes:
- Skip missing-metadata skills when
--allis set (and emit a notice instead of prompting). - Improve the warning text to point users to an interactive update (or reinstall) to add metadata.
- Add a regression test ensuring
--alldoes not prompt when metadata is missing.
Show a summary per file
| File | Description |
|---|---|
| pkg/cmd/skills/update/update.go | Avoids prompting for missing GitHub metadata when --all is used; improves skip notice text; updates command help text accordingly. |
| pkg/cmd/skills/update/update_test.go | Adds regression coverage ensuring --all skips no-metadata skills without prompting. |
Copilot's findings
Tip
Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Files reviewed: 2/2 changed files
- Comments generated: 0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13369
Summary
Fixes
gh skill update --allso it no longer prompts for skills that are missing GitHub metadata.When
--allis used, skills without GitHub metadata are skipped with a notice, matching the flag's "without prompting" behavior.Changes
--allis used instead of prompting interactively.gh skill update <skill>interactively to add metadata, or reinstall the skill.--alldoes not prompt for missing metadata.Testing
go test ./pkg/cmd/skills/update/... -run TestUpdateRun -count=1go test ./pkg/cmd/skills/... -count=1