fix(auth logout): clear credentials from git credential helper on logout#13450
Draft
babakks wants to merge 1 commit into
Draft
fix(auth logout): clear credentials from git credential helper on logout#13450babakks wants to merge 1 commit into
babakks wants to merge 1 commit into
Conversation
During login, if the user opts to authenticate git, the token is stored in the configured git credential helper via `git credential approve`. On logout, only gh's internal keyring was cleared, leaving the token in external helpers (e.g., osxkeychain, wincred). Now we also call `git credential reject` to remove it. Fixes #13111 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
This does not revoke it though. OAuth refresh token is long live (1 year-ish) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
During login, if the user opts to authenticate git, the token is stored in the configured git credential helper via
git credential approve. On logout, only gh's internal keyring was cleared, leaving the token in external helpers (e.g., osxkeychain, wincred). Now we also callgit credential rejectto remove it.Fixes #13111