Fix concurrent map writes in codespace port forwarding#13313
Draft
williammartin wants to merge 1 commit into
Draft
Fix concurrent map writes in codespace port forwarding#13313williammartin wants to merge 1 commit into
williammartin wants to merge 1 commit into
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When forwarding multiple ports concurrently with
gh cs ports forward, the dev-tunnelsTunnelManagermutates shared state on theTunnelobject inbuildUri(), which isn't goroutine-safe. This causes afatal error: concurrent map writespanic.Root cause
ForwardPortsruns all port forwards concurrently viaerrgroup, sharing a singleCodespaceConnection. The shallow copy inNewPortForwardermeans all forwarders share the sameTunnelManagerandTunnelpointers, so concurrent calls toGetTunnelPort/CreateTunnelPortrace on the shared map.Fix
*sync.Mutex(ManagerMu) toCodespaceConnection(as a pointer so it survives the struct value copy inNewPortForwarder)TunnelManageroperations that touch the sharedTunnelobjectConnectandRefreshPortsalready have their own synchronization and are left outside the lockTest
Added
TestConcurrentForwardPortDoesNotRacewhich forwards 10 ports concurrently from a shared connection, reproducing the race detected bygo test -race.