-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Introduce accessible prompter for screen readers (preview) #10710
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
49 commits
Select commit
Hold shift + click to select a range
202c1ad
feat(prompter): add accessible prompter support
BagToad 7b0c095
feat(md prompter): md prompt respects blankAllowed
BagToad e973ee3
fix(md prompter): accessible prompt allows blank
BagToad 92b1a8e
test(prompter): remove t.parallel calls
BagToad 88a98ea
feat(prompter): include `no` as false-y value
BagToad f7de9e0
test(prompter): `go-expect` based prompter tests
BagToad 94bbd26
fix(prompter): rename huhprompter
BagToad 0d7fd36
test(prompter): replace assert with require
BagToad e42af35
tests(prompter): rename huhprompter
BagToad e299b56
test(prompter): remove needless variable declaration
BagToad 8827803
test(prompter): skip vt10x tests on Windows
BagToad 88e6285
test(prompter): move to external package
BagToad 02fc12e
fix(linter): linter errors
BagToad 49ddacf
docs(prompter): doc prompter interface
BagToad a30df14
refactor(prompter): rename env var for speech synthesizer friendly pr…
BagToad 5b0d49c
test(prompter): more tests for bad input
BagToad 4cf048a
fix(prompter): input returns default when blank
BagToad 5c39e0b
fix(prompter): notes about Confirm default
BagToad 2e48cad
fix(prompter): remove impossible condition
BagToad 0b49522
refactor(prompter): less magic strings
BagToad f897001
doc(prompter): clarify comments
BagToad 5996f88
doc(envs): speech synthesis prompter
BagToad 2a851e3
test(prompter): fix race conditions
BagToad 0543aac
test(prompter): add basic survey prompter test
BagToad 6640740
doc: comment typos and formatting
BagToad c5ffb3c
test: use example.com in tests
BagToad fb80b5b
test(prompter): remove needless NO_COLOR set
BagToad d8d3874
fix(prompter): use os.lookupenv for accessible prompter
BagToad ef58e62
test(prompter): timeout for tests is 1s
BagToad c4be95a
refactor(prompter): remove unused variable
BagToad 8821f77
doc(prompter): remove senseless comment
BagToad 9cf3413
refactor(prompter): explicit return values
BagToad 19387b8
fix(prompter): rename GH_ACCESSIBLE_PROMPTER
BagToad fa03157
doc(help): label GH_ACCESSIBLE_PROMPTER as preview
BagToad d230b08
test(prompter): re-add skipped test for accessible confirm default
BagToad 8615632
Merge branch 'trunk' into kw/first-pass-accessible-prompter
BagToad 3b2e7f7
chore: go mod tidy
BagToad a34c9ea
doc(prompter env): accessible prompter includes braille reader
BagToad 8fc8486
refactor(prompter): rename speechSynthesizerFriendlyPrompter to acces…
BagToad 2f5e896
fix(prompter): update `huh` and fix tests
BagToad fab0de5
fix(prompter): pass io to `huh` and refactor tests
BagToad 4615069
chore: go mod tidy
BagToad 47d6032
test(prompter): use *testing.T instead
BagToad 8b70870
test(prompter): describe why echo is editorcmd
BagToad 9eee77a
test(prompter): doc how accessible prompter tests work
BagToad 20ff409
fix(prompter): remove needless default value assignment
BagToad b8cd094
Ensure markdown confirm prompt shows editor name
andyfeller 8cd3992
test(prompter): fix race condition
BagToad 70537de
test(prompter): fix invalid comment
BagToad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
test(prompter): doc how accessible prompter tests work
- Loading branch information
commit 9eee77a2bf290558d65c6111b5c9ed53bd5648fe
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.