Skip to content

fix(ui): remove back button from sign-in password compromised/pwned error screen #8280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ephem wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix(ui): remove back button from sign-in password compromised/pwned error screen #8280

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dd46bd3
Hide back button on sign-in password compromised/pwned screen
Ephem Apr 9, 2026
3a2b08b
Add changeset
Ephem Apr 9, 2026
18269d6
Remove no longer useful test
Ephem Apr 9, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Hide back button on sign-in password compromised/pwned screen 
This would take you back to re-enter the password, which never works so it was leading to a confusing dead end.
  • Loading branch information
@Ephem
Ephem committed Apr 9, 2026
commit dd46bd3ad64f36734816a2569980dd56a6292918
3 changes: 2 additions & 1 deletion packages/ui/src/components/SignIn/SignInFactorOne.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -155,7 +155,8 @@ function SignInFactorOneInternal(): JSX.Element {
}

if (showAllStrategies || showForgotPasswordStrategies) {
const canGoBack = factorHasLocalStrategy(currentFactor);
// Password errors are not recoverable by re-entering the password, so we hide the back button
const canGoBack = factorHasLocalStrategy(currentFactor) && !passwordErrorCode;
Copy link
Copy Markdown
Contributor

@dmoerner dmoerner Apr 9, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

passwordErrorCode is to me not a very clear name for this flag (it sounds more general than it is) but I confirmed that it is just a union of 'compromised' | 'pwned' so it's exactly what we want to check.


const toggle = showAllStrategies ? toggleAllStrategies : toggleForgotPasswordStrategies;
const backHandler = () => {
Expand Down