Skip to content

feat(expo): add native component theming via Expo config plugin #8243

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wobsoriano merged 12 commits into from
Apr 15, 2026
Merged

feat(expo): add native component theming via Expo config plugin #8243

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
3f2f058
feat(expo): add native component theming via Expo config plugin
chriscanin Apr 6, 2026
221e30c
fix(expo): apply Android theme after Clerk.initialize and use real Cl…
chriscanin Apr 8, 2026
b5af733
chore(expo): add changeset for native component theming
chriscanin Apr 8, 2026
19bc65a
fix(expo): reject 3-digit hex in theme validation and fix Android 8-d…
chriscanin Apr 10, 2026
3c703ef
fix(expo): stop removing UIUserInterfaceStyle when darkColors is present
chriscanin Apr 13, 2026
665952e
chore(expo): update changeset to reflect UIUserInterfaceStyle change
chriscanin Apr 13, 2026
64521d0
fix(expo): fix iOS theme parsing for clerk-ios 1.0.0 API
chriscanin Apr 13, 2026
2490b35
fix(expo): strict object validation in theme JSON and add tests
chriscanin Apr 13, 2026
578ac31
fix(expo): add top-level object validation and remove stale JSDoc
manovotny Apr 14, 2026
4786284
fix(expo): address review feedback on theming PR
chriscanin Apr 14, 2026
257de36
chore(expo): remove stale ClerkViewFactory.swift template
chriscanin Apr 14, 2026
1ae23f1
fix(expo): suppress no-require-imports lint error in theme test
chriscanin Apr 15, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(expo): apply Android theme after Clerk.initialize and use real Cl… 
…erkDesign signature

Two fixes needed to make the Android theme actually take effect:

1. Call loadThemeFromAssets() AFTER Clerk.initialize() instead of before.
   Clerk.initialize() accepts a `theme` parameter that defaults to null and
   assigns it to Clerk.customTheme on every call, which was wiping out the
   theme we just loaded.

2. Use the real ClerkDesign(borderRadius: Dp) constructor signature. The
   previous code passed nonexistent fontFamily and nullable borderRadius
   parameters that don't compile against clerk-android-ui.
  • Loading branch information
@chriscanin
chriscanin committed Apr 8, 2026
commit 221e30c298bc5cf028c490058b12a340f5a239a5
13 changes: 8 additions & 5 deletions packages/expo/android/src/main/java/expo/modules/clerk/ClerkExpoModule.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,8 +84,10 @@ class ClerkExpoModule(reactContext: ReactApplicationContext) :
.apply()
}

loadThemeFromAssets()
Clerk.initialize(reactApplicationContext, pubKey)
// Must be set AFTER Clerk.initialize() because initialize()
// resets customTheme to its `theme` parameter (default null).
loadThemeFromAssets()
Comment thread
manovotny marked this conversation as resolved.

// Wait for initialization to complete with timeout
try {
Expand Down Expand Up @@ -424,10 +426,11 @@ class ClerkExpoModule(reactContext: ReactApplicationContext) :
}

private fun parseDesign(json: JSONObject): ClerkDesign {
return ClerkDesign(
fontFamily = json.optString("fontFamily", null),
borderRadius = if (json.has("borderRadius")) json.getDouble("borderRadius").dp else null
)
return if (json.has("borderRadius")) {
ClerkDesign(borderRadius = json.getDouble("borderRadius").toFloat().dp)
} else {
ClerkDesign()
}
}

private fun parseHexColor(hex: String): Color? {
Expand Down
Loading