You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
Repository navigation
refactor(mosaic): share one invite form between the invite dialog and create organization - #10609
The invite members dialog and the create organization invite step each had their own copy of the invite form: the same values, the same role, rejection and submit wiring, and the same field props listed out in several types. Every change to the form, like the typed-address support in #10599, had to be made in both controllers and threaded through each prop list.
useInviteMembersForm in the invite controller now owns the form values, the default role, rejected addresses, submit availability and the submit. It returns one InviteMembersForm object.
The dialog takes open, onOpenChange, finalFocus and invite, down from 16 props. InviteMembersFields takes emailInputRef and invite, down from 11.
useCreateOrganizationInviteController is a thin wrapper around the shared hook, and its separate return type is gone.
Both views use the form's id and submit handler directly, so they no longer create a form id or call preventDefault.
Both flows resolve the default role the same way. The selected role stays empty until the user picks one, and the default fills in once roles load.
No user-facing behavior changes.
Refs CORE-4075
Checklist
pnpm test runs as expected.
pnpm build runs as expected.
(If applicable) JSDoc comments have been added or updated for any package exports
It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.
No actionable comments were generated in the recent review.
Walkthrough
The pull request adds useInviteMembersForm to manage invitation form state, validation, submission, and reset behavior. The organization creation and organization profile controllers use the shared form model. Their views, fields, and dialog receive that model instead of separate form values and callbacks. The dialog test checks invalid-address blocking and submission with the default role. The pull request also adds an empty changeset document.
clerk/javascript#10551: This PR changes the invite completion success path, which the shared form hook now handles.
clerk/javascript#10599: This PR adds controlled invite values and validation behavior used by the shared form hook.
clerk/javascript#10502: This PR added the create-organization invite controller and invite fields that this pull request updates to use the shared form.
Suggested reviewers:alexcarpenter, kylemac
Merge Risk: Minimal · up to f35ff
No actionable merge-blocking risk remains in the shared invitation-form refactor.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Title check
The title clearly and concisely describes the main change: sharing one invite form between the invite dialog and create-organization flow.
Description check
The description directly explains the shared useInviteMembersForm refactor, reduced prop surfaces, controller changes, and stated behavior.
Linked Issues check
Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check
Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 4 functions across 6 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Warning
Linked repositories: Some configured repositories could not be included in this review. Cross-repository analysis may be incomplete. Please check linked-repository access and settings.
Included review availability: This review used your included allowance. 4 included reviews remain after this review. Your included PR review attempts over the past 7 days set your current allowance at 6 reviews per hour.
On the rebased base, before and after behave identically: Member preselected, a draft-only address enables send, the existing member is flagged with the banner, and the remaining address sends, closes the dialog and toasts.
… create organization
useInviteMembersForm owns the invite values, the default role, rejected
addresses, submit availability, and the submit. The invite dialog and
the create organization invite step take it as a single invite prop
instead of repeating each field, and use its form id and submit handler
directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Stacked on #10599.
The invite members dialog and the create organization invite step each had their own copy of the invite form: the same values, the same role, rejection and submit wiring, and the same field props listed out in several types. Every change to the form, like the typed-address support in #10599, had to be made in both controllers and threaded through each prop list.
useInviteMembersFormin the invite controller now owns the form values, the default role, rejected addresses, submit availability and the submit. It returns oneInviteMembersFormobject.open,onOpenChange,finalFocusandinvite, down from 16 props.InviteMembersFieldstakesemailInputRefandinvite, down from 11.useCreateOrganizationInviteControlleris a thin wrapper around the shared hook, and its separate return type is gone.preventDefault.No user-facing behavior changes.
Refs CORE-4075
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change