Repository navigation
fix(ui): keep impersonation button aligned with pointer - #10241
Draft
joshrowley wants to merge 1 commit into
Draft
joshrowley wants to merge 1 commit into
joshrowley wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 00117d9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Comment |
@clerk/astro
@clerk/backend
@clerk/chrome-extension
@clerk/clerk-js
@clerk/electron
@clerk/electron-passkeys
@clerk/eslint-plugin
@clerk/expo
@clerk/expo-biometrics
@clerk/expo-google-signin
@clerk/expo-native-components
@clerk/expo-passkeys
@clerk/express
@clerk/fastify
@clerk/hono
@clerk/localizations
@clerk/mosaic
@clerk/nextjs
@clerk/nuxt
@clerk/react
@clerk/react-router
@clerk/shared
@clerk/tanstack-react-start
@clerk/testing
@clerk/ui
@clerk/upgrade
@clerk/vue
commit: |
1 of 9 tasks
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
This is a draft PR generated by AI, this will be updated with a human written summary before requesting review.
Description
Dragging the impersonation button can move it faster than the cursor and select text on the page. Calculate its position from the pointer's viewport coordinates and the button's position at drag start, keeping both in CSS pixels. Prevent selection when dragging and clean up listeners on release, cancellation, window blur, and unmount. Keep the sign-out link clickable.
To check the behavior, start an impersonation session in an app using the local UI build. Hover over the button, drag it across the page, and release within the viewport. It should follow the pointer and stay where released without selecting page text. Repeat at a different browser zoom or display scale, then click Sign out and confirm that the session ends.
Before and after in a controlled browser fixture with a mocked session. Both versions receive the same pointer input; movement values are replayed at 2× to reproduce the coordinate mismatch. The original button moves twice as far and leaves the viewport. The fixed button follows the pointer.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change