Repository navigation
chore(mosaic): export isReverificationError - #10214
austincalvelage wants to merge 19 commits into
Conversation
Also refactors tests to feature tests
…ms into their controllers
…rting it through the view
… into their controllers
…heir confirmation dialogs
A model that maps its own errors can now let reverification errors through, the way save() already does, so its callback can be wrapped in useReverificationFlow.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 7902229 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
96262dd to
3f482fd
Compare
Description
Exports
isReverificationErrorfrompackages/mosaic/src/utils/errors.ts.save()already rethrows reverification errors, so a model callback that uses it can be wrapped inuseReverificationFlow. A model that maps its own errors has no way to do the same, because the check was private. The password model is the first one that needs it (#10194): it formats complexity and breached-password errors itself, and must let a required or cancelled reverification through untouched.No behavior changes.
docs/models.mdgains a sentence pointing at the helper.Stacked on #10203.
Checklist
pnpm testruns as expected.pnpm buildruns as expected.Type of change