Skip to content

Bump actions/setup-java from v1.4.3 to v2#509

Merged
lukehutch merged 1 commit into
latestfrom
dependabot/github_actions/actions/setup-java-v2
Apr 6, 2021
Merged

Bump actions/setup-java from v1.4.3 to v2#509
lukehutch merged 1 commit into
latestfrom
dependabot/github_actions/actions/setup-java-v2

Conversation

@dependabot
Copy link
Copy Markdown
Contributor

@dependabot dependabot Bot commented on behalf of github Apr 6, 2021

Bumps actions/setup-java from v1.4.3 to v2.

Commits
  • 8764a52 Rename v2-preview to v2 in docs and tests (#151)
  • b53500d Merge "v2-preview" branch into "main" (#150)
  • ebb424f Beatify "main" warning about breaking changes (#144)
  • 9c7940b Add breaking change warning to 'main' branch (#138)
  • fc62cca V2 setup-java ADR (#97)
  • e73e96a Merge pull request #131 from actions/v-malob/update-codeowners
  • ea31b1d Update CODEOWNERS
  • ff0054d Merge pull request #123 from dmitry-shibanov/fix-documentation-for-gpg-import...
  • 81290cd change imported to exported
  • 546dae7 Merge pull request #122 from dmitry-shibanov/update-docs-for-maven-and-gpg
  • Additional commits viewable in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [actions/setup-java](https://github.com/actions/setup-java) from v1.4.3 to v2.
- [Release notes](https://github.com/actions/setup-java/releases)
- [Commits](actions/setup-java@v1.4.3...8764a52)

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot dependabot Bot added dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code labels Apr 6, 2021
@lukehutch lukehutch merged commit 7ae722c into latest Apr 6, 2021
@dependabot dependabot Bot deleted the dependabot/github_actions/actions/setup-java-v2 branch April 6, 2021 05:14
@thc202
Copy link
Copy Markdown

thc202 commented Apr 6, 2021

@lukehutch note that the ci workflow is no longer running (since the rename of the main branch to latest?).

With v2 of setup-java you need to indicate the Java distribution.

@lukehutch
Copy link
Copy Markdown
Member

I'm not sure what you mean -- these PRs are integrated just fine into the latest branch.

@thc202
Copy link
Copy Markdown

thc202 commented Apr 6, 2021

The workflow is configured to just run on master, e.g.

@lukehutch
Copy link
Copy Markdown
Member

@thc202 Ah! Thank you for pointing that out.

I added the distribution tag:

64de755

I also made CI run on "latest" branch:

7c50f7e

@lukehutch
Copy link
Copy Markdown
Member

@thc202 I checked some old CI results, and it looks like GitHub was smartly redirecting usage of the branch name "master" to "latest", since CI builds and tests were running OK before this change. But it was a good catch anyway.

@thc202
Copy link
Copy Markdown

thc202 commented Apr 6, 2021

The history of the CI workflow does not seem to indicate that though, before the branch update the last run was when it was still master.

@lukehutch
Copy link
Copy Markdown
Member

Click on any checkin in that list, targeted at the master branch, and all the builds are green. (The logs aren't available though, because they are too old...)

@thc202
Copy link
Copy Markdown

thc202 commented Apr 6, 2021

Sure, but those are old ones, last one in master was 8 months ago (probably when the branch was renamed).

@lukehutch
Copy link
Copy Markdown
Member

I'm pretty sure I renamed the branch around mid-June 2020, so 10 months ago. But either way, thanks for catching the problem!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file github_actions Pull requests that update Github_actions code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants