Skip to content

⚠️ CONFLICT! Lineage pull request for: skeleton#107

Merged
jsf9k merged 8 commits intodevelopfrom
lineage/skeleton
Sep 4, 2025
Merged

⚠️ CONFLICT! Lineage pull request for: skeleton#107
jsf9k merged 8 commits intodevelopfrom
lineage/skeleton

Conversation

@cisagovbot
Copy link
Copy Markdown

@cisagovbot cisagovbot commented Aug 14, 2025

Lineage Pull Request: CONFLICT

Achtung!!!

Lineage has created this pull request to incorporate new changes found in an upstream repository:

Upstream repository: https://github.com/cisagov/skeleton-packer.git
Remote branch: HEAD

Check the changes in this pull request to ensure they won't cause issues with your project.

The lineage/skeleton branch has one or more unresolved merge conflicts that you must resolve before merging this pull request!

How to resolve the conflicts

  1. Take ownership of this pull request by removing any other assignees.

  2. Clone the repository locally, and reapply the merge:

    git clone git@github.com:cisagov/teamserver-packer.git teamserver-packer
    cd teamserver-packer
    git remote add skeleton https://github.com/cisagov/skeleton-packer.git
    git remote set-url --push skeleton no_push
    git switch develop
    git switch --create lineage/skeleton --track origin/develop
    git pull skeleton HEAD
    git status
  3. Review the changes displayed by the status command. Fix any conflicts and possibly incorrect auto-merges.

  4. After resolving each of the conflicts, add your changes to the branch, commit, and push your changes:

    git add version.txt 
    git commit
    git push --force --set-upstream origin lineage/skeleton

    Note that you may append to the default merge commit message that git creates for you, but please do not delete the existing content. It provides useful information about the merge that is being performed.

  5. Wait for all the automated tests to pass.

  6. Confirm each item in the "Pre-approval checklist" below.

  7. Remove any of the checklist items that do not apply.

  8. Ensure every remaining checkbox has been checked.

  9. Mark this draft pull request "Ready for review".

✅ Pre-approval checklist

  • ✌️ The conflicts in this pull request have been resolved.
  • All relevant type-of-change labels have been added.
  • All relevant repo and/or project documentation has been updated to reflect the changes in this PR.
  • All new and existing tests pass.
  • Bump major, minor, patch, pre-release, and/or build versions as appropriate via the bump_version script if this repository is versioned and the changes in this PR warrant a version bump.
  • Verify that the new AMI functions as expected in our dev-a COOL deployment.
  • Create a pre-release (necessary if and only if the pre-release version was bumped).
  • Verify that the pre-release functions as expected in our staging-a COOL deployment.

✅ Pre-merge checklist

  • Finalize version.

✅ Post-merge checklist

  • Create a release (necessary if and only if the version was bumped).

Note

You are seeing this because one of this repository's maintainers has configured Lineage to open pull requests.

For more information:

🛠 Lineage configurations for this project are stored in .github/lineage.yml

📚 Read more about Lineage

@cisagovbot cisagovbot added the upstream update This issue or pull request pulls in upstream updates label Aug 14, 2025
@jsf9k jsf9k unassigned dav3r and mcdonnnj Aug 18, 2025
@jsf9k jsf9k force-pushed the lineage/skeleton branch from 6d5e449 to 584ffc3 Compare August 18, 2025 18:38
@jsf9k jsf9k added documentation This issue or pull request improves or adds to documentation version bump This issue or pull request increments the version number packer Pull requests that update Packer code labels Aug 18, 2025
This playbook does not appear to have actually done anything in quite
a while, and it is failing on Trixie because there is no systemd
service named cloud-init.
@jsf9k
Copy link
Copy Markdown
Member

jsf9k commented Aug 19, 2025

This pull request is failing its checks because the latest release of PowerShell/PowerShell does not yet support the version of libicu on Debian Trixie (76).

@jsf9k jsf9k marked this pull request as ready for review September 4, 2025 15:23
@jsf9k jsf9k requested review from a team, coffeegist and m1j09830 September 4, 2025 15:23
Copy link
Copy Markdown
Member

@dav3r dav3r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@dv4harr10
Copy link
Copy Markdown
Contributor

Hi Team @ALL , When I go to the Readme.md file under the Resources section and click on the 2 links for Trixie they return a 404 not found error. I'm not sure if this is just due to I lack a permissions.

@mcdonnnj
Copy link
Copy Markdown
Member

mcdonnnj commented Sep 4, 2025

Hi Team @ALL , When I go to the Readme.md file under the Resources section and click on the 2 links for Trixie they return a 404 not found error. I'm not sure if this is just due to I lack a permissions.

This is likely an issue with using terraform-docs on a Packer template.

Copy link
Copy Markdown
Member

@mcdonnnj mcdonnnj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM ✔

@jsf9k jsf9k merged commit f6b0fba into develop Sep 4, 2025
15 checks passed
@jsf9k jsf9k deleted the lineage/skeleton branch September 4, 2025 18:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

documentation This issue or pull request improves or adds to documentation packer Pull requests that update Packer code upstream update This issue or pull request pulls in upstream updates version bump This issue or pull request increments the version number

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants