preparing to add Org in the repo name#3
Merged
FoamyGuy merged 3 commits intocircuitpython:mainfrom Jun 20, 2021
Merged
Conversation
lesamouraipourpre
suggested changes
Jun 5, 2021
Contributor
lesamouraipourpre
left a comment
There was a problem hiding this comment.
Two more tweaks and everything else looks grand.
| :target: https://github.com/circuitpython/CircuitPython_Org_DisplayIO_Annotation/actions | ||
| :alt: Build Status | ||
|
|
||
|
|
Contributor
There was a problem hiding this comment.
At line 37 below, a newline is needed before 'Installing from PyPI'
At line 42 below, remove the adafruit-
Collaborator
Author
There was a problem hiding this comment.
Forgot to check in on this back when it happened. Thanks for looking this over and catching those!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These changes are needing for renaming the repository to have Org in the name.
The name of the repository should be changed to
CircuitPython_Org_DisplayIO_Annotationat the same time that this gets merged.