Conversation
|
The code from this repo was moved to ts-shared. I think we should move that function to https://github.com/chronicled/ts-shared/tree/develop/types/common |
Author
|
@pbsf got it. I will open another PR. Do we need to keep https://github.com/chronicled/platform-utils-javascript and https://github.com/chronicled/platform-utils-js repos around in this case? Seems like we have 3 different repos with the same code. |
|
We should confirm with @gokulkrishnaa. The application is not using either of these two, just ts-shared. |
Author
|
Closing this PR in lieu of https://github.com/chronicled/ts-shared/pull/191 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This function is being used in both CBK Admin and our infrastructure apps. Moving it here to keep our codebase DRY.