Skip to content

feature: only flush non-pending downlinks on enqueue#897

Merged
brocaar merged 1 commit intochirpstack:masterfrom
formaticus:fix/filter-flushed-downlinks-based-on-is-pending
Apr 13, 2026
Merged

feature: only flush non-pending downlinks on enqueue#897
brocaar merged 1 commit intochirpstack:masterfrom
formaticus:fix/filter-flushed-downlinks-based-on-is-pending

Conversation

@formaticus
Copy link
Copy Markdown
Contributor

Hello.

As discussed in #892, we could filter out the already transmitted downlinks from the queue flush on the call to enqueue. That allows previously sent downlinks from being acked once the device communicates back.

I kept the existing flush_for_dev_eui function as-is and created another flush_non_pending_for_dev_eui function to be called by enqueue as the former is also used in other methods like flush_queue, activate where it sounds more reasonable to flush all downlinks.

Thank you.

@brocaar brocaar merged commit 1382332 into chirpstack:master Apr 13, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants