feature: only flush non-pending downlinks on enqueue#897
Merged
brocaar merged 1 commit intochirpstack:masterfrom Apr 13, 2026
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello.
As discussed in #892, we could filter out the already transmitted downlinks from the queue flush on the call to
enqueue. That allows previously sent downlinks from being acked once the device communicates back.I kept the existing
flush_for_dev_euifunction as-is and created anotherflush_non_pending_for_dev_euifunction to be called byenqueueas the former is also used in other methods likeflush_queue,activatewhere it sounds more reasonable to flush all downlinks.Thank you.