Repository navigation
Handle nonexistent or inaccessible startup cwd gracefully in wspbus - #2087
Open
DYNOSuprovo wants to merge 2 commits into
Open
DYNOSuprovo wants to merge 2 commits into
DYNOSuprovo wants to merge 2 commits into
Conversation
Signed-off-by: DYNOSuprovo <DYNOSuprovo@users.noreply.github.com>
for more information, see https://pre-commit.ci
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2055
Summary
When
cherrypyis imported in an environment where the current working directory was removed or is inaccessible,wspbus.pycrashed during module import because_startup_cwd = os.getcwd()was called unguarded at top level.This change:
(FileNotFoundError, OSError)when initializing_startup_cwdat import time, falling back toNone.os.chdir(_startup_cwd)in_do_execvso that if_startup_cwdisNoneor raises(FileNotFoundError, OSError), it does not prevent process restart or crash.cherrypy/test/test_bus.pyverifying that importing with a nonexistent working directory succeeds and that_do_execvhandles_startup_cwd=Noneand inaccessible directories gracefully.