feat: add show/hide toolbar toggle in view menu#1100
Open
mvanhorn wants to merge 1 commit intochartdb:mainfrom
Open
feat: add show/hide toolbar toggle in view menu#1100mvanhorn wants to merge 1 commit intochartdb:mainfrom
mvanhorn wants to merge 1 commit intochartdb:mainfrom
Conversation
Add a toggle option in the View menu to show/hide the toolbar on the canvas, following the same pattern as existing show/hide toggles (minimap, cardinality, field attributes). The preference is persisted to localStorage. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
All contributors have signed the CLA ✍️ ✅ |
Author
|
I have read the CLA Document and I hereby sign the CLA |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #497
Summary
LocalConfigContextpatternChanges
local-config-context.tsx- addedshowToolbar/setShowToolbarto the context interface and defaultslocal-config-provider.tsx- added localStorage-backed state and persistence forshow_toolbarmenu.tsx- added toggle menu item in the View menu (between minimap and the zoom-on-scroll separator)canvas.tsx- conditionally renders the toolbar<Controls>wrapper based onshowToolbarshow_toolbarandhide_toolbartranslation keysTest plan
Developed with AI assistance (Claude Code)