Skip to content

fix(cli): #833 - #919

Closed
jjangga0214 wants to merge 1 commit into
changesets:mainfrom
jjangga0214:fix/833
Closed

jjangga0214 wants to merge 1 commit into
changesets:mainfrom
jjangga0214:fix/833

Conversation

@jjangga0214

@jjangga0214 jjangga0214 commented Aug 17, 2022 •

Copy link
Copy Markdown

Thanks for this awesome project!

Close #833

@changeset-bot

changeset-bot Bot commented Aug 17, 2022 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 146d283

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codesandbox-ci

codesandbox-ci Bot commented Aug 17, 2022 •

Copy link
Copy Markdown

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 146d283:

Sandbox Source
Vanilla Configuration

@Andarist Andarist left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test case covering for the fixed behavior?

@gao-sun

gao-sun commented Oct 21, 2022

Copy link
Copy Markdown

we need this. @Andarist is there anyway we can help with to push it forward?

@Andarist

Copy link
Copy Markdown
Member

I have a really busy time at work rn. I will be reviewing PRs here etc when I get some spare time after the current crunch. Other than that - you could write a test case for this as it's still missing here.

@geekact

geekact commented Feb 28, 2023

Copy link
Copy Markdown

Any message here in 2023? This PR is very useful for me.

@iamjaredwalters

Copy link
Copy Markdown

Anything we can help with to get this across the line?

@yykyy123123

Copy link
Copy Markdown

这个这么久了 还没更吗

@bluwy

bluwy commented Jun 26, 2026

Copy link
Copy Markdown
Member

fixed by #1361

@bluwy bluwy closed this Jun 26, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cannot ignore internal package

7 participants