Remove invalid error handler from git.findCommitAndParent - #611
Merged
bluwy merged 1 commit intoNov 18, 2025
Merged
Conversation
|
bluwy
approved these changes
Oct 9, 2024
Andarist
added a commit
to mihkeleidast/changesets
that referenced
this pull request
Jun 26, 2026
…ets try to retrieve commits that added files (changesets#584) * Avoid an infinite loop when git commands fail to execute when Changesets try to retrieve commits that added files * Remove a invalid error handler from git command (changesets#611) * Revert impossibly non-0 cases * Update --------- Co-authored-by: Leonardo Metzger <leonardo.metzger@outlook.com> Co-authored-by: bluwy <bjornlu.dev@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this PR resolves the issue with the tests.
Return with non-zero code from
gitcommand in methodfindCommitAndParentseems to be an accepted behaivior. Not throwing an error there is not an issue.As an example, in the scenario that we have a shallow clone with 5 commits and the commit that we searching is 10 commits behind, the method
findCommitAndParentwill not find the commit and the parent. In this case thedo-whileloop must do another iteration with a deepen clone.Merges into #584