Skip to content

rework publish flow, start splitting out PM-specific logic - #2155

Merged
Andarist merged 85 commits into
mainfrom
publish-fns
Jul 22, 2026
Merged

rework publish flow, start splitting out PM-specific logic#2155
Andarist merged 85 commits into
mainfrom
publish-fns

Conversation

@beeequeue

@beeequeue beeequeue commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

todo: add long explanation of why splitting up this pr just didn't work

the unindented list of published packages is fixed by this PR: bombshell-dev/clack#584

  • log publish errors somehow
  • make sure git tag behavior is consistent with git-tag command

recordings:

interactive, 2fa required: https://asciinema.org/a/43rIq4XG0hrapPpy

@beeequeue beeequeue added this to the v3 milestone Jul 11, 2026
@changeset-bot

changeset-bot Bot commented Jul 11, 2026 •
edited
Loading

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 279e934

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

beeequeue
beeequeue commented Jul 11, 2026
View reviewed changes
Comment thread packages/cli/src/commands/publish/publishPackages.ts Outdated
bluwy
bluwy reviewed Jul 13, 2026
View reviewed changes
Comment thread packages/cli/src/lib/npm.ts Outdated
Comment thread packages/cli/src/commands/publish/index.ts Outdated
@beeequeue
beeequeue force-pushed the publish-fns branch 2 times, most recently from 574631d to c01261a Compare July 15, 2026 12:45
@beeequeue
beeequeue marked this pull request as ready for review July 15, 2026 13:04
@beeequeue
beeequeue requested review from Andarist and bluwy July 15, 2026 13:04
@codecov

codecov Bot commented Jul 15, 2026 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 78.03468% with 114 lines in your changes missing coverage. Please review.
✅ Project coverage is 84.55%. Comparing base (a736a20) to head (279e934).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/lib/npm.ts 72.13% 25 Missing and 9 partials ⚠️
packages/cli/src/lib/yarn.ts 64.86% 19 Missing and 7 partials ⚠️
packages/cli/src/lib/pnpm.ts 67.94% 20 Missing and 5 partials ⚠️
packages/cli/src/commands/publish/index.ts 90.90% 10 Missing and 2 partials ⚠️
...ackages/cli/src/commands/publish/getPublishTool.ts 33.33% 6 Missing and 2 partials ⚠️
packages/cli/src/commands/pack/index.ts 50.00% 3 Missing and 1 partial ⚠️
...es/cli/src/commands/publish-plan/getPublishPlan.ts 76.47% 4 Missing ⚠️
scripts/test-utils/src/index.ts 88.88% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2155      +/-   ##
==========================================
+ Coverage   83.05%   84.55%   +1.50%     
==========================================
  Files          76       80       +4     
  Lines        2992     3121     +129     
  Branches      822      877      +55     
==========================================
+ Hits         2485     2639     +154     
+ Misses        460      428      -32     
- Partials       47       54       +7

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

bluwy
bluwy reviewed Jul 15, 2026
View reviewed changes

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left out some small nits as it's not worth addressing given the hot changes in this area recently, but I left one comment about the file organization below which I felt slightly strongly of to address/discuss.

Otherwise, the new publish separation looks great to me. I wouldn't put the otp re-prompt as a blocker for v3, but it'd be nice to address it when we have the time.

Comment thread packages/cli/src/lib/pnpm.ts Outdated
Comment thread packages/cli/src/commands/git-tag/utils.ts
@Andarist Andarist mentioned this pull request Jul 21, 2026
Closed
@Andarist
Andarist enabled auto-merge July 22, 2026 21:17
@Andarist
Andarist added this pull request to the merge queue Jul 22, 2026
Merged via the queue into main with commit 5a8119b Jul 22, 2026
14 of 15 checks passed
@Andarist
Andarist deleted the publish-fns branch July 22, 2026 21:32
@changesets-org-version-bot changesets-org-version-bot Bot mentioned this pull request Jul 22, 2026
Merged
@mixelburg mixelburg mentioned this pull request Jul 31, 2026
Closed
This was referenced Jul 31, 2026
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@Andarist Andarist Andarist approved these changes
@bluwy bluwy bluwy approved these changes

Assignees

No one assigned

Labels

npm pnpm yarn

Projects

None yet

Milestone

v3

Development

Successfully merging this pull request may close these issues.

3 participants

@beeequeue @Andarist @bluwy