Fixed accidental success logs on failed npm publishes - #2113
Merged
Conversation
🦋 Changeset detectedLatest commit: 5419723 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Andarist
commented
Jun 23, 2026
| log.success( | ||
| `Published ${c.blue(result.name)}@${c.green(result.version)}!`, | ||
| ); | ||
| if (result.result === "published") { |
Member
Author
There was a problem hiding this comment.
it feels we should be printing errors here too (or successes elsewere) - this logging is a little bit spread out through the code right now. But I don't have time to refactor this right now.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2113 +/- ##
==========================================
+ Coverage 85.12% 85.49% +0.37%
==========================================
Files 66 66
Lines 2528 2531 +3
Branches 698 700 +2
==========================================
+ Hits 2152 2164 +12
+ Misses 346 337 -9
Partials 30 30 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
bluwy
approved these changes
Jun 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.