Chunk releases using topological sorting - #2100

🦋 Changeset detected

Latest commit: 3160332

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Codecov Report

❌ Patch coverage is 98.18182% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 82.98%. Comparing base (830443c) to head (3160332).

@@            Coverage Diff             @@
##             main    #2100      +/-   ##
==========================================
+ Coverage   81.64%   82.98%   +1.34%     
==========================================
  Files          66       66              
  Lines        2479     2504      +25     
  Branches      673      679       +6     
==========================================
+ Hits         2024     2078      +54     
+ Misses        409      383      -26     
+ Partials       46       43       -3     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

Should or can this be done in assemble-release-plan as mentioned in #238?

Also, should we allow publishing still with cycles? We can warn instead. We currently already publish non-topologically, and that has worked out fine for a long while, so publishing with a best-effort order is still fine I think.

Should or can this be done in assemble-release-plan as mentioned in #238?

See #238 (comment)

We could also sort in assemble-release-plan but that wouldn't really help with publishes interrupted in the middle etc. assemble-release-plan participates in changeset version and not changeset publish

Also, should we allow publishing still with cycles? We can warn instead. We currently already publish non-topologically, and that has worked out fine for a long while, so publishing with a best-effort order is still fine I think.

I also considered adding an option to allow/disallow cycles - but I intentionally have started with the least permissive behavior here to hear out your thoughts on this.

I think warnings would be OK for now.

I made it to warn now