Conversation
Co-authored-by: bluwy <bjornlu.dev@gmail.com>
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1979 +/- ##
==========================================
- Coverage 84.57% 84.46% -0.12%
==========================================
Files 80 80
Lines 3125 3135 +10
Branches 878 887 +9
==========================================
+ Hits 2643 2648 +5
- Misses 427 432 +5
Partials 55 55 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
beeequeue
left a comment
There was a problem hiding this comment.
i still don't have write access, but i can do it this way instead :^)
Co-authored-by: Adam Haglund <adam@haglund.dev>
✅ Deploy Preview for changesets ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
- rewrite getting-started - rewrite concepts -> origins - rewrite common-questions -> faq - delete what-are-changesets (covered in getting-started) - delete dictionary (explain everything inline where possible)
fix #756 Co-authored-by: Melanie Seltzer <melanieseltzer1@gmail.com>
Co-Authored-By: Emmet Moore <130148281+emmet-opinionx@users.noreply.github.com>
|
Warning Review the following alerts detected in dependencies. According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.
|
Co-authored-by: Emelia Smith <ThisIsMissEm@users.noreply.github.com>
beeequeue
left a comment
There was a problem hiding this comment.
small comments i added while reviewing, not blocking though
| In this approach, a pull request may be merged if no changeset is present, and a missing changeset does not cause a failure in CI. Our [Changesets GitHub Bot](https://github.com/apps/changeset-bot) is the best way to prompt for changesets without making them blocking. | ||
|
|
||
| It comments on PRs of whether changesets are present and gives you link to add your own changeset as a maintainer to smooth over merging pull requests without waiting for the contributor to add a changeset. | ||
|
|
There was a problem hiding this comment.
I'll update this part altogether later
|
|
||
| ```json [.changeset/config.json] | ||
| { | ||
| "baseBranch": "v1" |
There was a problem hiding this comment.
should we recommend using the same pattern we do (maintenance/vX)?
There was a problem hiding this comment.
Yeah I think we can change this if we also mention that for automation to set the glob as "maintenance/v*"
Ready to merge. It's at a state where most drastic changes are done, and changes later can be made as PRs.
Netlify may need to be updated later to use
mainas the target branch for deployments.NO NEED TO NORMAL MERGE THIS. JUST SQUASH MERGE.
https://changesets.dev