Skip to content

fix: allow unmatched ignore globs - #1964

Closed
IgorGanapolsky wants to merge 1 commit into
changesets:mainfrom
IgorGanapolsky:codex/upstream-changesets-1794-ignore-globs
Closed

fix: allow unmatched ignore globs#1964
IgorGanapolsky wants to merge 1 commit into
changesets:mainfrom
IgorGanapolsky:codex/upstream-changesets-1794-ignore-globs

Conversation

@IgorGanapolsky

Copy link
Copy Markdown

Fixes #1794.

Summary

  • allow unmatched glob expressions in the ignore config option
  • keep exact missing package names as validation errors
  • add a regression test for an unmatched ignore glob expanding to an empty ignore list
  • add a changeset for @changesets/config

This supports generated package folders such as prisma-client-* that may exist locally after install/postinstall but not in a release automation checkout.

Verification

  • yarn jest packages/config/src/index.test.ts --runInBand
  • yarn types:check
  • yarn eslint packages/config/src/index.ts packages/config/src/index.test.ts --ext .ts
  • yarn prettier --check packages/config/src/index.ts packages/config/src/index.test.ts .changeset/quiet-globs-ignore.md

@changeset-bot

changeset-bot Bot commented May 4, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 6efe58d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 4 packages
Name Type
@changesets/config Patch
@changesets/apply-release-plan Patch
@changesets/cli Patch
@changesets/get-release-plan Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented May 4, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.87%. Comparing base (ff767d2) to head (6efe58d).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1964      +/-   ##
==========================================
+ Coverage   83.85%   83.87%   +0.01%     
==========================================
  Files          56       56              
  Lines        2465     2468       +3     
  Branches      743      749       +6     
==========================================
+ Hits         2067     2070       +3     
  Misses        392      392              
  Partials        6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@beeequeue beeequeue mentioned this pull request May 7, 2026
32 tasks
@ssrisuwrrn455-maker

This comment was marked as off-topic.

@beeequeue

Copy link
Copy Markdown
Member

thank you for the PR!

this is something we are considering for the next major version, and we have a branch (next) we are using to work on it.

could you re-open a PR against that branch instead?
it will require a few changes due us migrating from micromatch to picomatch, so let us know if you need help!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Changeset fails on ignore pattern when there's no matches

3 participants