replace spawndamnit with tinyexec - #1875
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: 4de524d The changes in this PR will be included in the next version bump. This PR includes changesets to release 7 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## next #1875 +/- ##
==========================================
+ Coverage 82.50% 82.52% +0.01%
==========================================
Files 53 53
Lines 2384 2357 -27
Branches 698 697 -1
==========================================
- Hits 1967 1945 -22
+ Misses 375 370 -5
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Andarist
reviewed
Mar 8, 2026
Andarist
reviewed
Mar 8, 2026
Comment on lines
-95
to
-101
| const activeProcesses = new Set<ChildProcess>(); | ||
|
|
||
| onExit(() => { | ||
| for (let child of activeProcesses) { | ||
| child.kill(SIGTERM); | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
oh wow, this dates back to: df424a4#diff-bc83e21a29c754b54d601fc5b2ab7be373aba7da931f30bf0b7a986dbf87defa
I have NO recollection of adding this 😅
Andarist
reviewed
Mar 8, 2026
Andarist
reviewed
Mar 10, 2026
Andarist
reviewed
Mar 10, 2026
scutuatua-crypto
approved these changes
Mar 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
part of #1869
replaces
spawndamnitwith the smallertinyexecwhich will also dedupe much better as many other packages use it, as can even be seen in this repo! 😄the only change code-wise is that
tinyexecputs the node-specific options undernodeOptionsinstead of the root options objects: