Fixed resolution of changelog/commit scripts paths - #1667
Conversation
🦋 Changeset detectedLatest commit: b5824df The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## next #1667 +/- ##
==========================================
- Coverage 82.61% 81.91% -0.71%
==========================================
Files 54 54
Lines 2422 2449 +27
Branches 718 722 +4
==========================================
+ Hits 2001 2006 +5
- Misses 379 401 +22
Partials 42 42 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
bluwy
left a comment
There was a problem hiding this comment.
Do we need a changeset since the bug before was already released?
|
It's only released in the prerelease that is probably not downloaded by many. Given this shouldn't appear in the final changelog for v3 - I'd be OK with not including this changeset here. If you feel like it should be here regardless (which is fair) then I'll add one |
|
I would prefer adding since it helps with debugging later, or just bookkeeping since we're not getting much users I guess 😅 But it's how I'm accustomed to using changesets from Svelte & SvelteKit side where they do the same. In the final v3 release we could have a pass to remove these not-so-important changelogs though (I can help with that). Or maybe re-assess if including all the prerelease changelog in the stable entry is a good idea. Svelte/SvelteKit had to workaround it as they have like 300 prereleases choking changesets 😄 |
|
This needs a rebase, and I prefer a changeset too |
No description provided.