Skip to content

Fixed resolution of changelog/commit scripts paths - #1667

Merged
Andarist merged 5 commits into
nextfrom
fix/changelog-commit-modules
May 4, 2026
Merged

Fixed resolution of changelog/commit scripts paths#1667
Andarist merged 5 commits into
nextfrom
fix/changelog-commit-modules

Conversation

@Andarist

Copy link
Copy Markdown
Member

No description provided.

@Andarist
Andarist requested a review from bluwy May 12, 2025 11:01
@changeset-bot

changeset-bot Bot commented May 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: b5824df

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@changesets/apply-release-plan Patch
@changesets/cli Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented May 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 90.90909% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 81.91%. Comparing base (8e9afd1) to head (b5824df).
⚠️ Report is 2 commits behind head on next.

Files with missing lines Patch % Lines
packages/cli/src/commit/getCommitFunctions.ts 80.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             next    #1667      +/-   ##
==========================================
- Coverage   82.61%   81.91%   -0.71%     
==========================================
  Files          54       54              
  Lines        2422     2449      +27     
  Branches      718      722       +4     
==========================================
+ Hits         2001     2006       +5     
- Misses        379      401      +22     
  Partials       42       42              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy bluwy left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need a changeset since the bug before was already released?

@Andarist

Copy link
Copy Markdown
Member Author

It's only released in the prerelease that is probably not downloaded by many. Given this shouldn't appear in the final changelog for v3 - I'd be OK with not including this changeset here. If you feel like it should be here regardless (which is fair) then I'll add one

@bluwy

bluwy commented May 12, 2025

Copy link
Copy Markdown
Member

I would prefer adding since it helps with debugging later, or just bookkeeping since we're not getting much users I guess 😅 But it's how I'm accustomed to using changesets from Svelte & SvelteKit side where they do the same.

In the final v3 release we could have a pass to remove these not-so-important changelogs though (I can help with that). Or maybe re-assess if including all the prerelease changelog in the stable entry is a good idea. Svelte/SvelteKit had to workaround it as they have like 300 prereleases choking changesets 😄

@bluwy

bluwy commented May 4, 2026

Copy link
Copy Markdown
Member

This needs a rebase, and I prefer a changeset too

@Andarist
Andarist merged commit 81832f8 into next May 4, 2026
9 of 10 checks passed
@Andarist
Andarist deleted the fix/changelog-commit-modules branch May 4, 2026 08:39
@github-actions github-actions Bot mentioned this pull request May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants