Skip to content

Add no commit flag to CLI - #1585

Open
milofultz wants to merge 3 commits into
changesets:mainfrom
milofultz:no-commit-flag
Open

Add no commit flag to CLI#1585
milofultz wants to merge 3 commits into
changesets:mainfrom
milofultz:no-commit-flag

Conversation

@milofultz

Copy link
Copy Markdown

Often, we have staged changes and then make a changeset. This rolls up the staged changes with the changeset and is quite annoying.

Adding this --no-commit/-n flag will allow a user to make a changeset and not commit the newly created changeset.

@changeset-bot

changeset-bot Bot commented Feb 12, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: d18f248

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@changesets/cli Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov

codecov Bot commented Feb 12, 2025

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 33.33333% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 81.16%. Comparing base (5c2bac5) to head (d18f248).
⚠️ Report is 84 commits behind head on main.

Files with missing lines Patch % Lines
packages/cli/src/run.ts 0.00% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1585   +/-   ##
=======================================
  Coverage   81.16%   81.16%           
=======================================
  Files          54       54           
  Lines        2241     2241           
  Branches      669      673    +4     
=======================================
  Hits         1819     1819           
  Misses        417      417           
  Partials        5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@milofultz

milofultz commented Feb 12, 2025

Copy link
Copy Markdown
Author

The two lines that aren't covered are a destructuring (packages/cli/src/run.ts#L67) and a function invocation (packages/cli/src/run.ts#L69), so there's nothing functional to really test.

@milofultz

Copy link
Copy Markdown
Author

Not sure who would be the best for review, but I see that @bennypowers and @Andarist were recent contributors. Sorry if this is the wrong ping 🙇

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant