Skip to content

fix(assemble-release-plan): errors caused by non-standard packages - #1579

Closed
aui wants to merge 1 commit into
changesets:mainfrom
aui:fix/assemble-release-plan-prerelease
Closed

aui wants to merge 1 commit into
changesets:mainfrom
aui:fix/assemble-release-plan-prerelease

Conversation

@aui

@aui aui commented Feb 10, 2025

Copy link
Copy Markdown

If some internal packages in the workspace lack version numbers, it will cause changesets to crash.

I strictly check the input and throw error messages to let users know where they can improve their code to avoid confusion.

BUG:#835

@changeset-bot

changeset-bot Bot commented Feb 10, 2025

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 06f62fa

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aui aui changed the title fix(assemble-release-plan): errors caused by non-standard packages#835 fix(assemble-release-plan): errors caused by non-standard packages Feb 10, 2025
@codecov

codecov Bot commented Feb 10, 2025 •

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 66.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 80.96%. Comparing base (01c037c) to head (06f62fa).
⚠️ Report is 42 commits behind head on main.

Files with missing lines Patch % Lines
packages/assemble-release-plan/src/index.ts 66.66% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1579      +/-   ##
==========================================
- Coverage   81.00%   80.96%   -0.04%     
==========================================
  Files          54       54              
  Lines        2232     2238       +6     
  Branches      659      661       +2     
==========================================
+ Hits         1808     1812       +4     
- Misses        420      422       +2     
  Partials        4        4              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@bluwy

bluwy commented Nov 17, 2025

Copy link
Copy Markdown
Member

The linked issue was fixed by #1589, so I'll assume that we don't need this fix now. I'll close the PR, but thanks for contributing!

@bluwy bluwy closed this Nov 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants