Repository navigation
Default privatePackages.tag to true to match old buggy behavior - #1394
Closed
jakebailey wants to merge 1 commit into
Closed
jakebailey wants to merge 1 commit into
jakebailey wants to merge 1 commit into
Conversation
🦋 Changeset detectedLatest commit: 94ab951 The changes in this PR will be included in the next version bump. This PR includes changesets to release 4 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. |
|
That's why my packages stopped to have tags and therefor breaks the other steps. I'm glad that I found the reason. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Per #1383 (comment)
Due to a bug fixed in #1361,
tag: falsedid not actually have any effect, so private packages were still tagged. This surprised many people, so I think it may be worthwile to just default this to "true" to match the buggy behavior.