Repository navigation
Cleanup @changesets/git tests - #1029
Conversation
🦋 Changeset detectedLatest commit: adf66bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit adf66bd:
|
71bbe7a to
9a19bcc
Compare
emmatown
left a comment
There was a problem hiding this comment.
Seems fine besides missing missing changesets
chaance
left a comment
There was a problem hiding this comment.
Looks good overall. Just wondering if we need a changeset to top it off.
| export async function getCommitsThatAddFiles( | ||
| gitPaths: string[], | ||
| cwd: string | ||
| { cwd, short = false }: { cwd: string; short?: boolean } |
There was a problem hiding this comment.
Since this is exposed API, should we include a changeset to document it?
There was a problem hiding this comment.
Yeap, gonna add changesets before merging this - a few minor breaking changes got included here as part of the refactor.
This PR:
beforeEachhooks in favor of explicit setup per testgetCurrentCommitIdTODO:
@changesets/gitpackage since the second change could be seen as a breaking change