Repository navigation
Conversation
create_ec_pool() and create_ec_pool_pp() work on a cluster handle that the caller owns and keeps using, but most of their error paths shut it down. The error path for a failed "osd pool set allow_ec_optimizations" is worse: it shuts the cluster down and then sends another mon command on it (in C on the freed handle, followed by a second rados_shutdown()), and its pool delete looks the new pool up in a client osdmap that does not contain it yet, so the pool is never removed. Whenever that set fails, for example when a resent "osd pool create" is answered before the pool is committed, the EC test binaries crash instead of reporting a test failure. Leave the cluster connected on every error path of create_ec_pool() and create_ec_pool_pp(). create_one_ec_pool() shuts down the cluster it connected when the pool cannot be created, as create_one_ec_pool_pp() does. On the allow_ec_optimizations error path, wait for the latest osdmap and remove the pool, profile and rule with destroy_ec_pool() or destroy_ec_pool_pp(). Fixes: https://tracker.ceph.com/issues/83011 Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
create_ec_pool()andcreate_ec_pool_pp()work on a cluster handle that the caller owns and keeps using, but most of their error paths shut it down. After a failedosd pool set <pool> allow_ec_optimizations true, the error path also sends another mon command on the shut-down cluster. In C this uses the freedRadosClientand is followed by a secondrados_shutdown(). That path's pool delete also looks the new pool up in a client osdmap that does not have it yet, so the pool is left behind. Whenever the set fails, the EC test binaries crash instead of reporting a failure.The helpers leave the caller's cluster connected on every error path.
create_one_ec_pool()shuts down the cluster it connected, ascreate_one_ec_pool_pp()does. Theallow_ec_optimizationserror path waits for the latest osdmap and removes the pool, profile and rule withdestroy_ec_pool()ordestroy_ec_pool_pp().Checked on one mon whose default EC profile cannot take EC optimizations, so the set always fails. Without the fix
ceph_test_rados_api_io_ppsegfaults, and valgrind showsceph_test_rados_api_aioandceph_test_rados_api_watch_notifyusing the freedRadosClient. With it all three fail cleanly with the monitor's error, valgrind reports 0 errors, and no test pools are left.Fixes: https://tracker.ceph.com/issues/83011
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.
🤖 Raised by Claude Code.