Repository navigation
Conversation
The Objecter and the CephContext both observe crush_location. The Objecter copies the CephContext's parsed CrushLocation, but the config proxy calls the observers of a change in the order of their addresses, not the order in which they were added. When the Objecter's observer runs first, it copies the previous location, so a client whose crush_location changes at run time can keep sending localized reads to the OSDs of its old location. Parse the option in the Objecter's observer before copying it. unittest_splitop links unit-main, so that the new test has the global CephContext it needs. Found by the librados zone split-read tests, which move their client between zones and failed intermittently. Fixes: https://tracker.ceph.com/issues/82994 Assisted-by: Claude Code
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Objecter and the CephContext both observe
crush_location. On a change, the Objecter copies the CephContext's parsed location, but the config proxy calls a change's observers in the order of their addresses, not the order they were added in. When the Objecter's observer runs first, it copies the previous location, so a client whosecrush_locationchanges at run time stays one change behind and sends localized reads to the OSDs of its old location.The Objecter now parses the option in its own observer before copying it. The new unit test runs the Objecter's observer before the CephContext's; it fails without the fix and passes with it.
unittest_splitopnow linksunit-main, so the test has the global CephContext it needs.Found by the librados zone split-read tests of #72643, which move their client between zones and failed in about 1 of 5 runs.
Fixes: https://tracker.ceph.com/issues/82994
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.
🤖 Raised by Claude Code.