Repository navigation
Conversation
With _GNU_SOURCE, glibc 2.43 returns const char * from strstr() and strchr() for a const string, so assigning the result to char * fails with -Werror on clang and gcc. Make the pointers into dev_str const. parse_options() writes into its argument, so pass it the non-const optarg. A missing -o was marked by the address of the const EMPTY_STRING; the now non-const opts uses NULL instead, so drop EMPTY_STRING. Assisted-by: claude-opus-5-5 Signed-off-by: Dominik Raddatz <dominik.raddatz@clyso.com>
The parent writes buf to the pipe without setting it, which clang 21 reports with -Wuninitialized-const-pointer. The child only waits for the byte, so any value works. Assisted-by: claude-opus-5-5 Signed-off-by: Dominik Raddatz <dominik.raddatz@clyso.com>
BucketRemoveDeleteMarker declares and captures instance_2 and instance_3 but never uses them, which clang reports with -Wunused-lambda-capture. Assisted-by: claude-opus-5-5 Signed-off-by: Dominik Raddatz <dominik.raddatz@clyso.com>
Doracly
force-pushed
the
clang-Werror-fixes
branch
from
November 10, 2026 11:38
7dd7bf2 to
1199f9a
Compare
Contributor
Author
adamemerson
approved these changes
Nov 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes three errors in a clang 21
-Werrorbuild on Ubuntu 26.04 (glibc 2.43). CI doesn't see them: make check uses clang 19 and glibc 2.35, builds only theteststarget, and uses-Werrorfor C++ only._GNU_SOURCE, glibc 2.43 returnsconst char *fromstrstr()andstrchr()for a const argument, so clang and gcc reject assigning the result tochar *. The pointers into the device string are now const, andparse_options()takes the writableoptarg. A missing-ois marked byNULLinstead of the address ofEMPTY_STRING, which is dropped; behaviour is unchanged.test_trim_capswrites an uninitialized byte to a pipe (-Wuninitialized-const-pointer, new in clang 21).test_d4n_filtercaptures two variables it never uses (-Wunused-lambda-capture).ceph_test_rgw_d4n_filterisn't part of theteststarget, so CI never compiles it.No functional change.
Contribution Guidelines
To sign and title your commits, please refer to Submitting Patches to Ceph.
If you are submitting a fix for a stable branch (e.g. "quincy"), please refer to Submitting Patches to Ceph - Backports for the proper workflow.
When filling out the below checklist, you may click boxes directly in the GitHub web UI. When entering or editing the entire PR message in the GitHub web UI editor, you may also select a checklist item by adding an
xbetween the brackets:[x]. Spaces and capitalization matter when checking off items this way.Checklist
Show available Jenkins commands
jenkins test classic perfJenkins Job | Jenkins Job Definitionjenkins test crimson perfJenkins Job | Jenkins Job Definitionjenkins test signedJenkins Job | Jenkins Job Definitionjenkins test make checkJenkins Job | Jenkins Job Definitionjenkins test make check arm64Jenkins Job | Jenkins Job Definitionjenkins test submodulesJenkins Job | Jenkins Job Definitionjenkins test dashboardJenkins Job | Jenkins Job Definitionjenkins test dashboard cephadmJenkins Job | Jenkins Job Definitionjenkins test apiJenkins Job | Jenkins Job Definitionjenkins test docsReadTheDocs | Github Workflow Definitionjenkins test ceph-volume allJenkins Jobs | Jenkins Jobs Definitionjenkins test windowsJenkins Job | Jenkins Job Definitionjenkins test rook e2eJenkins Job | Jenkins Job DefinitionYou must only issue one Jenkins command per-comment. Jenkins does not understand
comments with more than one command.