Skip to content
This repository was archived by the owner on Dec 23, 2023. It is now read-only.

Stackdriver exporter: add workload.googleapis.com as a supported external domain#2106

Merged
punya merged 2 commits into
census-instrumentation:masterfrom
dashpole:workload_domain
Sep 15, 2022
Merged

Stackdriver exporter: add workload.googleapis.com as a supported external domain#2106
punya merged 2 commits into
census-instrumentation:masterfrom
dashpole:workload_domain

Conversation

@dashpole
Copy link
Copy Markdown
Contributor

This allows metric descriptors to be created for metrics in that domain

@dashpole dashpole requested review from a team and rghetia as code owners September 14, 2022 19:14
@punya
Copy link
Copy Markdown
Contributor

punya commented Sep 14, 2022

Error: eckstyle] [ERROR] /home/runner/work/opencensus-java/opencensus-java/exporters/stats/stackdriver/src/main/java/io/opencensus/exporter/stats/stackdriver/CreateMetricDescriptorExporter.java:47: Line is longer than 100 characters (found 109). [LineLength]

Please fix.

@dashpole
Copy link
Copy Markdown
Contributor Author

I think I fixed it

@punya
Copy link
Copy Markdown
Contributor

punya commented Sep 15, 2022

Still seeing

The following files are not formatted properly:

/home/runner/work/opencensus-java/opencensus-java/exporters/stats/stackdriver/src/main/java/io/opencensus/exporter/stats/stackdriver/CreateMetricDescriptorExporter.java

@punya punya merged commit a37129e into census-instrumentation:master Sep 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants